Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute, r=dao
authorSubhdeep Saha <subhdeepsaha@gmail.com>
Thu, 09 Mar 2017 21:06:35 +0530
changeset 346758 c6bc677cfa1a394d4a2b07b2f835449aaf08cd6f
parent 346757 66227bcf53be060615219c18d8b316c9a5aa28b5
child 346759 4782fb1a555b801c5aa00d3eb087c5d93f73e881
push id38605
push userdgottwald@mozilla.com
push dateThu, 09 Mar 2017 17:23:40 +0000
treeherderautoland@c6bc677cfa1a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1345773
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute, r=dao MozReview-Commit-ID: 9GSnGxJoNne
browser/base/content/browser-ctrlTab.js
--- a/browser/base/content/browser-ctrlTab.js
+++ b/browser/base/content/browser-ctrlTab.js
@@ -469,20 +469,20 @@ var ctrlTab = {
   },
 
   handleEvent: function ctrlTab_handleEvent(event) {
     switch (event.type) {
       case "SSWindowRestored":
         this._initRecentlyUsedTabs();
         break;
       case "TabAttrModified":
-        // tab attribute modified (i.e. label, busy, image, selected)
+        // tab attribute modified (i.e. label, busy, image)
         // update preview only if tab attribute modified in the list
         if (event.detail.changed.some(
-          (elem, ind, arr) => ["label", "busy", "image", "selected"].includes(elem))) {
+          (elem, ind, arr) => ["label", "busy", "image"].includes(elem))) {
           for (let i = this.previews.length - 1; i >= 0; i--) {
             if (this.previews[i]._tab && this.previews[i]._tab == event.target) {
               this.updatePreview(this.previews[i], event.target);
               break;
             }
           }
         }
         break;