Bug 1515023 Abort page load test when mitmproxy recording can not be found r=davehunt
authormarian.raiciof <marian.raiciof@softvision.ro>
Fri, 15 Feb 2019 10:48:25 +0000
changeset 459421 c5f15b5682b546a9b770fc2bcb355de32d79b089
parent 459420 9243ddacadcca22365599b018d279a026cc51b8c
child 459422 15158d921194d94000045378b00d8944d6dbb0e3
push id78263
push userdhunt@mozilla.com
push dateFri, 15 Feb 2019 10:49:05 +0000
treeherderautoland@c5f15b5682b5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdavehunt
bugs1515023
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1515023 Abort page load test when mitmproxy recording can not be found r=davehunt Differential Revision: https://phabricator.services.mozilla.com/D19649
testing/raptor/raptor/playback/mitmproxy.py
--- a/testing/raptor/raptor/playback/mitmproxy.py
+++ b/testing/raptor/raptor/playback/mitmproxy.py
@@ -149,16 +149,22 @@ class Mitmproxy(Playback):
         LOG.info("mitmdump path: %s" % mitmdump_path)
         LOG.info("recording path: %s" % mitmproxy_recording_path)
         LOG.info("recordings list: %s" % mitmproxy_recordings_list)
         LOG.info("browser path: %s" % browser_path)
 
         mitmproxy_recordings = []
         # recording names can be provided in comma-separated list; build py list including path
         for recording in mitmproxy_recordings_list:
+            if not os.path.isfile(os.path.join(mitmproxy_recording_path, recording)):
+                LOG.critical('Recording file {} cannot be found!'.
+                             format(os.path.join(mitmproxy_recording_path, recording)))
+                raise Exception('Recording file {} cannot be found!'.
+                                format(os.path.join(mitmproxy_recording_path, recording)))
+
             mitmproxy_recordings.append(os.path.join(mitmproxy_recording_path, recording))
 
         # cmd line to start mitmproxy playback using custom playback script is as follows:
         # <path>/mitmdump -s "<path>mitmdump-alternate-server-replay/alternate-server-replay.py
         #  <path>recording-1.mp <path>recording-2.mp..."
         param = os.path.join(here, 'alternate-server-replay.py')
         env = os.environ.copy()