Bug 1589345 - Fix a leftover comment to tell what PrioritizedEventQueue::mActive actually does, r=farre
authorOlli Pettay <Olli.Pettay@helsinki.fi>
Fri, 18 Oct 2019 10:35:47 +0000
changeset 498135 c1b0190a53476e04a3f79d056d177af0c30adfa0
parent 498134 747c5f90f2c3916f6d7bc537bd25deac589ae3b9
child 498136 7f379c7775ca17056153d034647146b383bb6912
push id98307
push useropettay@mozilla.com
push dateFri, 18 Oct 2019 13:13:00 +0000
treeherderautoland@c1b0190a5347 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfarre
bugs1589345
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1589345 - Fix a leftover comment to tell what PrioritizedEventQueue::mActive actually does, r=farre EnsureIsActive is called in two places, one is for non-idle tasks, the other for idle tasks https://searchfox.org/mozilla-central/rev/97976753a21c1731e18177de9e5ce78ea3b3da2d/xpcom/threads/PrioritizedEventQueue.cpp#212-214,286,288,303 Differential Revision: https://phabricator.services.mozilla.com/D49592
xpcom/threads/PrioritizedEventQueue.h
--- a/xpcom/threads/PrioritizedEventQueue.h
+++ b/xpcom/threads/PrioritizedEventQueue.h
@@ -193,15 +193,15 @@ class PrioritizedEventQueue final : publ
   TimeStamp mIdleToken;
 
   // The id of the last idle request to the cross-process idle scheduler.
   uint64_t mIdleRequestId = 0;
 
   RefPtr<ipc::IdleSchedulerChild> mIdleScheduler;
   bool mIdleSchedulerInitialized = false;
 
-  // mActive tells whether the event queue is running non-idle tasks.
+  // mActive tells whether the event queue is running tasks.
   bool mActive = true;
 };
 
 }  // namespace mozilla
 
 #endif  // mozilla_PrioritizedEventQueue_h