Bug 1647695 - Uniformizing naming conventions within fields of ChildProcInfoDictionary;r=tarek
☠☠ backed out by c0ca500c0330 ☠ ☠
authorDavid Teller <dteller@mozilla.com>
Mon, 03 Aug 2020 12:49:59 +0000
changeset 543116 c1af633ab74e82ec366d33be66251022e184e817
parent 543115 3417fe7200bdb67e7b46554968a52bf0956fdc76
child 543117 2a5cab9f413fabe1cb7d5819a82225ecfefd5fa0
push id123234
push userdteller@mozilla.com
push dateMon, 03 Aug 2020 12:53:04 +0000
treeherderautoland@c1af633ab74e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstarek
bugs1647695
milestone81.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1647695 - Uniformizing naming conventions within fields of ChildProcInfoDictionary;r=tarek Differential Revision: https://phabricator.services.mozilla.com/D83667
dom/chrome-webidl/ChromeUtils.webidl
widget/tests/browser/browser_test_procinfo.js
--- a/dom/chrome-webidl/ChromeUtils.webidl
+++ b/dom/chrome-webidl/ChromeUtils.webidl
@@ -549,17 +549,17 @@ dictionary ChildProcInfoDictionary {
   long long pid = 0;
   DOMString filename = "";
   unsigned long long virtualMemorySize = 0;
   long long residentSetSize = 0;
   unsigned long long cpuUser = 0;
   unsigned long long cpuKernel = 0;
   sequence<ThreadInfoDictionary> threads = [];
   // Firefox info
-  unsigned long long ChildID = 0;
+  unsigned long long childID = 0;
   UTF8String origin = "";
   WebIDLProcType type = "web";
 };
 
 dictionary ParentProcInfoDictionary {
   // System info
   long long pid = 0;
   DOMString filename = "";
--- a/widget/tests/browser/browser_test_procinfo.js
+++ b/widget/tests/browser/browser_test_procinfo.js
@@ -39,16 +39,20 @@ add_task(async function test_proc_info()
           Assert.ok(
             parentProc.threads.some(thread => thread.name),
             "At least one of the threads of the parent process is named"
           );
         }
 
         for (var i = 0; i < parentProc.children.length; i++) {
           let childProc = parentProc.children[i];
+
+          // By definition, `childID != 0` for children processes.
+          Assert.ok(childProc.childID > 0);
+
           Assert.notEqual(
             childProc.type,
             "browser",
             "Child proc type should not be browser"
           );
           Assert.notEqual(
             childProc.type,
             "unknown",