☠☠ backed out by 49739b62d4dc ☠ ☠ | |
author | Gijs Kruitbosch <gijskruitbosch@gmail.com> |
Wed, 28 Jun 2017 16:55:44 +0100 | |
changeset 366585 | bdcdd4d23c77c8669a9e6043a38b3d1cd0a1947b |
parent 366584 | b77dc8c1e68f0cd79f1d5d1038205b1183ba90b2 |
child 366586 | 49739b62d4dc0b58a11996c5072edbe2e9582cd8 |
push id | 45670 |
push user | gijskruitbosch@gmail.com |
push date | Thu, 29 Jun 2017 09:59:40 +0000 |
treeherder | autoland@bdcdd4d23c77 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | jaws |
bugs | 1373016 |
milestone | 56.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/browser/base/content/browser.css +++ b/browser/base/content/browser.css @@ -1232,17 +1232,16 @@ toolbarpaletteitem[place="palette"] > #d } #customization-container[photon] #customization-panelHolder { padding-top: 10px; padding-bottom: 10px; } #customization-panelHolder > #widget-overflow-fixed-list { - padding-bottom: 50px; /* Make sure there's always space to drop stuff. */ flex: 0 1 auto; /* Size to content, but allow ourselves to shrink */ display: flex; flex-direction: column; overflow-y: auto; } #customization-container:not([photon]) #customization-panelHolder { overflow-y: hidden;
--- a/browser/components/customizableui/CustomizeMode.jsm +++ b/browser/components/customizableui/CustomizeMode.jsm @@ -407,17 +407,19 @@ CustomizeMode.prototype = { // Force layout reflow to ensure the animation runs, // and make it async so it doesn't affect the timing. this.visiblePalette.clientTop; this.visiblePalette.setAttribute("showing", "true"); }, 0); this._updateEmptyPaletteNotice(); this._updateLWThemeButtonIcon(); - this.maybeShowTip(panelHolder); + if (!AppConstants.MOZ_PHOTON_THEME) { + this.maybeShowTip(panelHolder); + } this._handler.isEnteringCustomizeMode = false; if (!gPhotonStructure) { window.PanelUI.contents.removeAttribute("customize-transitioning"); } CustomizableUI.dispatchToolboxEvent("customizationready", {}, window); this._enableOutlinesTimeout = window.setTimeout(() => {
--- a/browser/components/customizableui/content/panelUI.inc.xul +++ b/browser/components/customizableui/content/panelUI.inc.xul @@ -348,17 +348,18 @@ <panelmultiview mainViewId="widget-overflow-mainView"> <panelview id="widget-overflow-mainView" context="toolbar-context-menu"> #endif <vbox id="widget-overflow-scroller"> <vbox id="widget-overflow-list" class="widget-overflow-list" overflowfortoolbar="nav-bar"/> <toolbarseparator id="widget-overflow-fixed-separator" hidden="true"/> - <vbox id="widget-overflow-fixed-list" class="widget-overflow-list" hidden="true"/> + <vbox id="widget-overflow-fixed-list" class="widget-overflow-list" hidden="true" + emptylabel="&customizeMode.emptyOverflowList.description;"/> </vbox> #ifdef MOZ_PHOTON_THEME </panelview> </panelmultiview> #endif </panel> <panel id="customization-tipPanel"
--- a/browser/locales/en-US/chrome/browser/browser.dtd +++ b/browser/locales/en-US/chrome/browser/browser.dtd @@ -849,16 +849,17 @@ you can use these alternative items. Oth <!ENTITY customizeMode.toolbars2 "Toolbars"> <!ENTITY customizeMode.lwthemes "Themes"> <!ENTITY customizeMode.lwthemes.myThemes "My Themes"> <!ENTITY customizeMode.lwthemes.recommended "Recommended"> <!ENTITY customizeMode.lwthemes.menuManage "Manage"> <!ENTITY customizeMode.lwthemes.menuManage.accessKey "M"> <!ENTITY customizeMode.lwthemes.menuGetMore "Get More Themes"> <!ENTITY customizeMode.lwthemes.menuGetMore.accessKey "G"> +<!ENTITY customizeMode.emptyOverflowList.description "Drag and drop items here to keep them within reach but out of your toolbar…"> <!ENTITY getUserMedia.selectCamera.label "Camera to share:"> <!ENTITY getUserMedia.selectCamera.accesskey "C"> <!ENTITY getUserMedia.selectMicrophone.label "Microphone to share:"> <!ENTITY getUserMedia.selectMicrophone.accesskey "M"> <!ENTITY getUserMedia.audioCapture.label "Audio from the tab will be shared."> <!ENTITY getUserMedia.allWindowsShared.message "All visible windows on your screen will be shared.">
--- a/browser/themes/shared/customizableui/customizeMode.inc.css +++ b/browser/themes/shared/customizableui/customizeMode.inc.css @@ -565,9 +565,36 @@ toolbarpaletteitem[place="toolbar"]:not( margin-bottom: -1px; } #customization-container:not([photon]) #customization-panelWrapper > .panel-arrowbox > .panel-arrow[side="top"] { margin-inline-end: 0; margin-inline-start: 22.35em; } +%ifdef MOZ_PHOTON_THEME +#customization-panelHolder > #widget-overflow-fixed-list:not(:empty) { + padding-bottom: 50px; /* Make sure there's always space to drop stuff. */ +} + +#customization-panelHolder > #widget-overflow-fixed-list:empty { + background-image: url("chrome://browser/skin/customizableui/empty-overflow-panel.png"); + background-position: center top 10px; + background-size: 218px 134px; + background-repeat: no-repeat; +} + +#customization-panelHolder > #widget-overflow-fixed-list:empty::after { + content: attr(emptylabel); + padding: 154px 10px 10px; /* 154 = 134 for the image, 10px space on either side. */ + text-align: center; + display: block; +} + +@media (min-resolution: 1.1dppx) { + #customization-panelHolder > #widget-overflow-fixed-list:empty { + background-image: url("chrome://browser/skin/customizableui/empty-overflow-panel@2x.png"); + } +} + +%else %include customizeTip.inc.css +%endif
--- a/browser/themes/shared/jar.inc.mn +++ b/browser/themes/shared/jar.inc.mn @@ -29,26 +29,31 @@ * skin/classic/browser/controlcenter/connection.svg (../shared/controlcenter/connection.svg) * skin/classic/browser/controlcenter/mcb-disabled.svg (../shared/controlcenter/mcb-disabled.svg) skin/classic/browser/controlcenter/extension.svg (../shared/controlcenter/extension.svg) * skin/classic/browser/controlcenter/permissions.svg (../shared/controlcenter/permissions.svg) * skin/classic/browser/controlcenter/tracking-protection.svg (../shared/controlcenter/tracking-protection.svg) skin/classic/browser/controlcenter/warning-gray.svg (../shared/controlcenter/warning-gray.svg) skin/classic/browser/controlcenter/warning-yellow.svg (../shared/controlcenter/warning-yellow.svg) skin/classic/browser/customizableui/customizeFavicon.ico (../shared/customizableui/customizeFavicon.ico) + skin/classic/browser/customizableui/menuPanel-customizeFinish.png (../shared/customizableui/menuPanel-customizeFinish.png) + skin/classic/browser/customizableui/menuPanel-customizeFinish@2x.png (../shared/customizableui/menuPanel-customizeFinish@2x.png) +#ifdef MOZ_PHOTON_THEME + skin/classic/browser/customizableui/empty-overflow-panel.png (../shared/customizableui/empty-overflow-panel.png) + skin/classic/browser/customizableui/empty-overflow-panel@2x.png (../shared/customizableui/empty-overflow-panel@2x.png) +#else skin/classic/browser/customizableui/customize-illustration.png (../shared/customizableui/customize-illustration.png) skin/classic/browser/customizableui/customize-illustration@2x.png (../shared/customizableui/customize-illustration@2x.png) skin/classic/browser/customizableui/customize-illustration-rtl.png (../shared/customizableui/customize-illustration-rtl.png) skin/classic/browser/customizableui/customize-illustration-rtl@2x.png (../shared/customizableui/customize-illustration-rtl@2x.png) skin/classic/browser/customizableui/info-icon-customizeTip.png (../shared/customizableui/info-icon-customizeTip.png) skin/classic/browser/customizableui/info-icon-customizeTip@2x.png (../shared/customizableui/info-icon-customizeTip@2x.png) - skin/classic/browser/customizableui/menuPanel-customizeFinish.png (../shared/customizableui/menuPanel-customizeFinish.png) - skin/classic/browser/customizableui/menuPanel-customizeFinish@2x.png (../shared/customizableui/menuPanel-customizeFinish@2x.png) skin/classic/browser/customizableui/panelarrow-customizeTip.png (../shared/customizableui/panelarrow-customizeTip.png) skin/classic/browser/customizableui/panelarrow-customizeTip@2x.png (../shared/customizableui/panelarrow-customizeTip@2x.png) +#endif skin/classic/browser/customizableui/subView-arrow-back-inverted.png (../shared/customizableui/subView-arrow-back-inverted.png) skin/classic/browser/customizableui/subView-arrow-back-inverted@2x.png (../shared/customizableui/subView-arrow-back-inverted@2x.png) skin/classic/browser/customizableui/subView-arrow-back-inverted-rtl.png (../shared/customizableui/subView-arrow-back-inverted-rtl.png) skin/classic/browser/customizableui/subView-arrow-back-inverted-rtl@2x.png (../shared/customizableui/subView-arrow-back-inverted-rtl@2x.png) skin/classic/browser/customizableui/whimsy.png (../shared/customizableui/whimsy.png) skin/classic/browser/customizableui/whimsy@2x.png (../shared/customizableui/whimsy@2x.png) skin/classic/browser/downloads/contentAreaDownloadsView.css (../shared/downloads/contentAreaDownloadsView.css) skin/classic/browser/downloads/download-blocked.svg (../shared/downloads/download-blocked.svg)