author | Kevin Jones <kevinhowjones@gmail.com> |
Fri, 03 Mar 2017 18:58:27 +0100 | |
changeset 346007 | bcda4b323e9fa1e3a2f6b0fc3ed3ca4ec09117c1 |
parent 345909 | 6bd0aa101e17792acc0c5094d195a48d4fc20a37 |
child 346008 | 4daed4761e8d02845bc657bef016be99b358e55e |
push id | 38387 |
push user | cbook@mozilla.com |
push date | Mon, 06 Mar 2017 10:11:11 +0000 |
treeherder | autoland@937f89775395 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | dao |
bugs | 1344212 |
milestone | 54.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
browser/base/content/browser.js | file | annotate | diff | comparison | revisions | |
browser/base/content/tabbrowser.xml | file | annotate | diff | comparison | revisions |
--- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -5074,17 +5074,16 @@ nsBrowserAccess.prototype = { let tab = win.gBrowser.loadOneTab(aURI ? aURI.spec : "about:blank", { triggeringPrincipal: aTriggeringPrincipal, referrerURI: aReferrer, referrerPolicy: aReferrerPolicy, userContextId: aUserContextId, fromExternal: aIsExternal, inBackground: loadInBackground, forceNotRemote: aForceNotRemote, - forceBrowserInsertion: true, opener: aOpener, }); let browser = win.gBrowser.getBrowserForTab(tab); if (needToFocusWin || (!loadInBackground && aIsExternal)) win.focus(); return browser;
--- a/browser/base/content/tabbrowser.xml +++ b/browser/base/content/tabbrowser.xml @@ -1509,17 +1509,17 @@ var aSkipAnimation; var aForceNotRemote; var aPreferredRemoteType; var aNoReferrer; var aUserContextId; var aSameProcessAsFrameLoader; var aOriginPrincipal; var aOpener; - var aForceBrowserInsertion; + var aCreateLazyBrowser; if (arguments.length == 2 && typeof arguments[1] == "object" && !(arguments[1] instanceof Ci.nsIURI)) { let params = arguments[1]; aTriggeringPrincipal = params.triggeringPrincipal aReferrerURI = params.referrerURI; aReferrerPolicy = params.referrerPolicy; aCharset = params.charset; @@ -1533,17 +1533,17 @@ aForceNotRemote = params.forceNotRemote; aPreferredRemoteType = params.preferredRemoteType; aNoReferrer = params.noReferrer; aUserContextId = params.userContextId; aSameProcessAsFrameLoader = params.sameProcessAsFrameLoader; aOriginPrincipal = params.originPrincipal; aOpener = params.opener; aIsPrerendered = params.isPrerendered; - aForceBrowserInsertion = params.forceBrowserInsertion; + aCreateLazyBrowser = params.createLazyBrowser; } var bgLoad = (aLoadInBackground != null) ? aLoadInBackground : Services.prefs.getBoolPref("browser.tabs.loadInBackground"); var owner = bgLoad ? null : this.selectedTab; var tab = this.addTab(aURI, { triggeringPrincipal: aTriggeringPrincipal, @@ -1553,17 +1553,17 @@ postData: aPostData, ownerTab: owner, allowThirdPartyFixup: aAllowThirdPartyFixup, fromExternal: aFromExternal, relatedToCurrent: aRelatedToCurrent, skipAnimation: aSkipAnimation, allowMixedContent: aAllowMixedContent, forceNotRemote: aForceNotRemote, - forceBrowserInsertion: aForceBrowserInsertion, + createLazyBrowser: aCreateLazyBrowser, preferredRemoteType: aPreferredRemoteType, noReferrer: aNoReferrer, userContextId: aUserContextId, originPrincipal: aOriginPrincipal, sameProcessAsFrameLoader: aSameProcessAsFrameLoader, opener: aOpener, isPrerendered: aIsPrerendered }); if (!bgLoad) @@ -2192,17 +2192,17 @@ var aPreferredRemoteType; var aNoReferrer; var aUserContextId; var aEventDetail; var aSameProcessAsFrameLoader; var aOriginPrincipal; var aDisallowInheritPrincipal; var aOpener; - var aForceBrowserInsertion; + var aCreateLazyBrowser; if (arguments.length == 2 && typeof arguments[1] == "object" && !(arguments[1] instanceof Ci.nsIURI)) { let params = arguments[1]; aTriggeringPrincipal = params.triggeringPrincipal; aReferrerURI = params.referrerURI; aReferrerPolicy = params.referrerPolicy; aCharset = params.charset; @@ -2218,17 +2218,17 @@ aNoReferrer = params.noReferrer; aUserContextId = params.userContextId; aEventDetail = params.eventDetail; aSameProcessAsFrameLoader = params.sameProcessAsFrameLoader; aOriginPrincipal = params.originPrincipal; aDisallowInheritPrincipal = params.disallowInheritPrincipal; aOpener = params.opener; aIsPrerendered = params.isPrerendered; - aForceBrowserInsertion = params.forceBrowserInsertion; + aCreateLazyBrowser = params.createLazyBrowser; } // if we're adding tabs, we're past interrupt mode, ditch the owner if (this.mCurrentTab.owner) this.mCurrentTab.owner = null; var t = document.createElementNS(NS_XUL, "tab"); @@ -2332,19 +2332,18 @@ t.linkedBrowser = b; this._tabForBrowser.set(b, t); t.permanentKey = b.permanentKey; t._browserParams = { uriIsAboutBlank, remoteType, usingPreloadedContent }; - // If we're creating a blank tab, create a lazy browser. - // Otherwise insert the browser into the document now. - if (uriIsAboutBlank && !aForceBrowserInsertion) { + // If the caller opts in, create a lazy browser. + if (aCreateLazyBrowser) { this._createLazyBrowser(t); } else { this._insertBrowser(t); } // Dispatch a new tab notification. We do this once we're // entirely done, so that things are in a consistent state // even if the event listener opens or closes tabs.