Backed out changeset cade5cf8a0ed (bug 1543696) for browser-chrome at toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
authorCoroiu Cristina <ccoroiu@mozilla.com>
Sat, 13 Apr 2019 15:01:25 +0300
changeset 469402 b60534ec20b8bc628b691d72f4c3100b4f31b97f
parent 469401 aad1c782f75344b91db649f459dab7691d6a8942
child 469403 7f7f40328e31e35e21ec587ddc5320688f5e8469
push id83130
push userccoroiu@mozilla.com
push dateSat, 13 Apr 2019 12:02:15 +0000
treeherderautoland@b60534ec20b8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1543696
milestone68.0a1
backs outcade5cf8a0ed653fae2b81f9de8219df426a847c
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset cade5cf8a0ed (bug 1543696) for browser-chrome at toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
toolkit/components/extensions/test/browser/browser_ext_themes_experiment.js
toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
--- a/toolkit/components/extensions/test/browser/browser_ext_themes_experiment.js
+++ b/toolkit/components/extensions/test/browser/browser_ext_themes_experiment.js
@@ -1,18 +1,16 @@
 "use strict";
 
 // This test checks whether the theme experiments work
 
 add_task(async function setup() {
-  if (AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS) {
-    await SpecialPowers.pushPrefEnv({
-      set: [["extensions.legacy.enabled", true]],
-    });
-  }
+  await SpecialPowers.pushPrefEnv({
+    set: [["extensions.legacy.enabled", true]],
+  });
 });
 
 add_task(async function test_experiment_static_theme() {
   let extension = ExtensionTestUtils.loadExtension({
     manifest: {
       theme: {
         colors: {
           some_color_property: "#ff00ff",
--- a/toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
+++ b/toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
@@ -68,19 +68,17 @@ add_task(async function test_dynamic_the
       `Unrecognized theme property found: ${property}.such_property`
     );
   }
 
   await extension.unload();
 });
 
 add_task(async function test_experiment() {
-  await SpecialPowers.pushPrefEnv({
-    set: [["extensions.legacy.enabled", true]],
-  });
+  Services.prefs.setBoolPref("extensions.legacy.enabled", true);
 
   info("Testing that experiments are handled correctly when legacy pref is enabled");
 
   let extension = ExtensionTestUtils.loadExtension({
     manifest: {
       theme: {
         properties: {
           such_property: "much_wow",
@@ -104,17 +102,17 @@ add_task(async function test_experiment(
       extension.startup,
       "Unrecognized theme property found: properties.unknown_property"
     );
   }
   await extension.unload();
 
   info("Testing that experiments are handled correctly when legacy pref is disabled");
 
-  await SpecialPowers.popPrefEnv();
+  Services.prefs.setBoolPref("extensions.legacy.enabled", false);
 
   extension = ExtensionTestUtils.loadExtension({
     manifest: {
       theme: {
         properties: {
           such_property: "much_wow",
         },
       },