Bug 1585351 - Bug 1460357 disabled AVX instructions for the mingw build; this is no longer needed r=lsalzman
authorTom Ritter <tom@mozilla.com>
Thu, 03 Oct 2019 21:02:16 +0000
changeset 496281 b50de96607f422c1b7a41ed3d5f43635747addfb
parent 496280 27df5399e032451d3bdebcd86155ec69da504c99
child 496282 97efcd0fa370b81345f54b1c85da75c42d59aedb
push id97152
push usertritter@mozilla.com
push dateFri, 04 Oct 2019 04:45:47 +0000
treeherderautoland@b50de96607f4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslsalzman
bugs1585351, 1460357
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1585351 - Bug 1460357 disabled AVX instructions for the mingw build; this is no longer needed r=lsalzman Bug 1460357 disabled AVX because gcc was generating unaligned instructions. But clang doesn't seem to do that. Differential Revision: https://phabricator.services.mozilla.com/D48072
gfx/skia/skia/src/opts/SkOpts_hsw.cpp
--- a/gfx/skia/skia/src/opts/SkOpts_hsw.cpp
+++ b/gfx/skia/skia/src/opts/SkOpts_hsw.cpp
@@ -2,17 +2,17 @@
  * Copyright 2018 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 // As described in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85525, MinGW will produce
 // unaligned instructions for this code, resulting in a crash.
-#if defined(__AVX2__) && !defined(__MINGW32__)
+#if defined(__AVX2__)
 
 #include <immintrin.h>
 #include <stdint.h>
 
 namespace hsw {
 
     void convolve_vertically(const int16_t* filter, int filterLen,
                              uint8_t* const* srcRows, int width,