Backed out changeset 479097530e46 (bug 1586913) for failing at test_login_item.html on a CLOSED TREE.
authorGurzau Raul <rgurzau@mozilla.com>
Wed, 09 Oct 2019 21:16:58 +0300
changeset 497027 b40d7c3da6f9a99285901732fc720ef4355dc117
parent 497026 4386f4316fea96827e54e9cab544b2c14a0387ed
child 497028 50c93e91923f1f4db59c8f8f1a160edae6e728a8
push id97602
push userrgurzau@mozilla.com
push dateWed, 09 Oct 2019 18:17:56 +0000
treeherderautoland@b40d7c3da6f9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1586913
milestone71.0a1
backs out479097530e46f2ee9aa1420d0283979582117e0a
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 479097530e46 (bug 1586913) for failing at test_login_item.html on a CLOSED TREE.
browser/components/aboutlogins/AboutLoginsChild.jsm
browser/components/aboutlogins/AboutLoginsParent.jsm
browser/components/aboutlogins/content/components/login-item.js
browser/components/enterprisepolicies/Policies.jsm
browser/components/enterprisepolicies/schemas/policies-schema.json
browser/locales/en-US/browser/policies/policies-descriptions.ftl
--- a/browser/components/aboutlogins/AboutLoginsChild.jsm
+++ b/browser/components/aboutlogins/AboutLoginsChild.jsm
@@ -64,17 +64,16 @@ class AboutLoginsChild extends ActorChil
             };
 
             messageManager.sendAsyncMessage(
               "AboutLogins:MasterPasswordRequest"
             );
           },
           // Default to enabled just in case a search is attempted before we get a response.
           masterPasswordEnabled: true,
-          passwordRevealVisible: true,
         };
         waivedContent.AboutLoginsUtils = Cu.cloneInto(
           AboutLoginsUtils,
           waivedContent,
           {
             cloneFunctions: true,
           }
         );
@@ -222,18 +221,16 @@ class AboutLoginsChild extends ActorChil
         break;
       case "AboutLogins:SetBreaches":
         this.sendToContent("SetBreaches", message.data);
         break;
       case "AboutLogins:Setup":
         this.sendToContent("Setup", message.data);
         Cu.waiveXrays(this.content).AboutLoginsUtils.masterPasswordEnabled =
           message.data.masterPasswordEnabled;
-        Cu.waiveXrays(this.content).AboutLoginsUtils.passwordRevealVisible =
-          message.data.passwordRevealVisible;
         break;
       case "AboutLogins:ShowLoginItemError":
         this.sendToContent("ShowLoginItemError", message.data);
         break;
       case "AboutLogins:SyncState":
         this.sendToContent("SyncState", message.data);
         break;
       case "AboutLogins:UpdateBreaches":
--- a/browser/components/aboutlogins/AboutLoginsParent.jsm
+++ b/browser/components/aboutlogins/AboutLoginsParent.jsm
@@ -406,19 +406,16 @@ var AboutLoginsParent = {
             playStoreBadgeLanguage,
           };
 
           messageManager.sendAsyncMessage("AboutLogins:Setup", {
             logins,
             syncState,
             selectedBadgeLanguages,
             masterPasswordEnabled: LoginHelper.isMasterPasswordSet(),
-            passwordRevealVisible: Services.policies.isAllowed(
-              "passwordReveal"
-            ),
           });
 
           await this._sendAllLoginRelatedObjects(logins, messageManager);
         } catch (ex) {
           if (ex.result != Cr.NS_ERROR_NOT_INITIALIZED) {
             throw ex;
           }
 
--- a/browser/components/aboutlogins/content/components/login-item.js
+++ b/browser/components/aboutlogins/content/components/login-item.js
@@ -722,24 +722,16 @@ export default class LoginItem extends H
     } else {
       delete this.dataset.editing;
       // Only reset the reveal checkbox when exiting 'edit' mode
       this._revealCheckbox.checked = false;
     }
   }
 
   _updatePasswordRevealState() {
-    if (
-      window.AboutLoginsUtils &&
-      !window.AboutLoginsUtils.passwordRevealVisible
-    ) {
-      this._revealCheckbox.hidden = true;
-      return;
-    }
-
     let titleId = this._revealCheckbox.checked
       ? "login-item-password-reveal-checkbox-hide"
       : "login-item-password-reveal-checkbox-show";
     document.l10n.setAttributes(this._revealCheckbox, titleId);
 
     let { checked } = this._revealCheckbox;
     let inputType = checked ? "text" : "password";
     this._passwordInput.type = inputType;
--- a/browser/components/enterprisepolicies/Policies.jsm
+++ b/browser/components/enterprisepolicies/Policies.jsm
@@ -445,24 +445,16 @@ var Policies = {
   DisableMasterPasswordCreation: {
     onBeforeUIStartup(manager, param) {
       if (param) {
         manager.disallowFeature("createMasterPassword");
       }
     },
   },
 
-  DisablePasswordReveal: {
-    onBeforeUIStartup(manager, param) {
-      if (param) {
-        manager.disallowFeature("passwordReveal");
-      }
-    },
-  },
-
   DisablePocket: {
     onBeforeAddons(manager, param) {
       if (param) {
         setAndLockPref("extensions.pocket.enabled", false);
       }
     },
   },
 
--- a/browser/components/enterprisepolicies/schemas/policies-schema.json
+++ b/browser/components/enterprisepolicies/schemas/policies-schema.json
@@ -206,20 +206,16 @@
     "DisableFormHistory": {
       "type": "boolean"
     },
 
     "DisableMasterPasswordCreation": {
       "type": "boolean"
     },
 
-    "DisablePasswordReveal": {
-      "type": "boolean"
-    },
-
     "DisablePocket": {
       "type": "boolean"
     },
 
     "DisablePrivateBrowsing": {
       "type": "boolean"
     },
 
--- a/browser/locales/en-US/browser/policies/policies-descriptions.ftl
+++ b/browser/locales/en-US/browser/policies/policies-descriptions.ftl
@@ -49,18 +49,16 @@ policy-DisableFirefoxScreenshots = Disab
 policy-DisableFirefoxStudies = Prevent { -brand-short-name } from running studies.
 
 policy-DisableForgetButton = Prevent access to the Forget button.
 
 policy-DisableFormHistory = Don’t remember search and form history.
 
 policy-DisableMasterPasswordCreation = If true, a master password can’t be created.
 
-policy-DisablePasswordReveal = Do not allow passwords to be revealed in saved logins.
-
 policy-DisablePocket = Disable the feature to save webpages to Pocket.
 
 policy-DisablePrivateBrowsing = Disable Private Browsing.
 
 policy-DisableProfileImport = Disable the menu command to Import data from another browser.
 
 policy-DisableProfileRefresh = Disable the Refresh { -brand-short-name } button in the about:support page.