author | Fred Lin <gasolin@mozilla.com> |
Thu, 13 Oct 2016 16:48:35 +0800 | |
changeset 317824 | b2f3dd7eec5d028034173a33e4e0ab7da805d8cd |
parent 317823 | 30137ab463a31576a01b78a31a6677604c5434de |
child 317825 | d8aafc5269fbf79582ad2f008d71942e35ba29f8 |
push id | 33163 |
push user | cbook@mozilla.com |
push date | Fri, 14 Oct 2016 06:14:53 +0000 |
treeherder | autoland@b2f3dd7eec5d [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | Honza |
bugs | 1309796 |
milestone | 52.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
new file mode 100644 --- /dev/null +++ b/devtools/client/netmonitor/.eslintrc @@ -0,0 +1,12 @@ +{ + // Extend from the devtools eslintrc. + "extends": "../../.eslintrc", + + "rules": { + // The netmonitor is being migrated to HTML and cleaned of + // chrome-privileged code, so this rule disallows requiring chrome + // code. Some files in the netmonitor disable this rule still. The + // goal is to enable the rule globally on all files. + "mozilla/reject-some-requires": [2, "^(chrome|chrome:.*|resource:.*|devtools/server/.*|.*\\.jsm|devtools/shared/platform/(chome|content)/.*)$"], + }, +}
--- a/devtools/client/netmonitor/har/har-automation.js +++ b/devtools/client/netmonitor/har/har-automation.js @@ -1,13 +1,13 @@ /* This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ "use strict"; - +/* eslint-disable mozilla/reject-some-requires */ const { Ci } = require("chrome"); const { Class } = require("sdk/core/heritage"); const { resolve } = require("promise"); const Services = require("Services"); loader.lazyRequireGetter(this, "HarCollector", "devtools/client/netmonitor/har/har-collector", true); loader.lazyRequireGetter(this, "HarExporter", "devtools/client/netmonitor/har/har-exporter", true); loader.lazyRequireGetter(this, "HarUtils", "devtools/client/netmonitor/har/har-utils", true);
--- a/devtools/client/netmonitor/har/har-exporter.js +++ b/devtools/client/netmonitor/har/har-exporter.js @@ -1,16 +1,17 @@ /* This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ "use strict"; - +/* eslint-disable mozilla/reject-some-requires */ const { Cc, Ci } = require("chrome"); const Services = require("Services"); +/* eslint-disable mozilla/reject-some-requires */ const { XPCOMUtils } = require("resource://gre/modules/XPCOMUtils.jsm"); const { resolve } = require("promise"); const { HarUtils } = require("./har-utils.js"); const { HarBuilder } = require("./har-builder.js"); XPCOMUtils.defineLazyGetter(this, "clipboardHelper", function () { return Cc["@mozilla.org/widget/clipboardhelper;1"] .getService(Ci.nsIClipboardHelper);
--- a/devtools/client/netmonitor/har/har-utils.js +++ b/devtools/client/netmonitor/har/har-utils.js @@ -1,15 +1,16 @@ /* This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ "use strict"; - +/* eslint-disable mozilla/reject-some-requires */ const { Ci, Cc, CC } = require("chrome"); +/* eslint-disable mozilla/reject-some-requires */ const { XPCOMUtils } = require("resource://gre/modules/XPCOMUtils.jsm"); XPCOMUtils.defineLazyGetter(this, "dirService", function () { return Cc["@mozilla.org/file/directory_service;1"] .getService(Ci.nsIProperties); }); XPCOMUtils.defineLazyGetter(this, "ZipWriter", function () {
--- a/devtools/client/netmonitor/netmonitor-controller.js +++ b/devtools/client/netmonitor/netmonitor-controller.js @@ -30,16 +30,17 @@ var BrowserLoaderModule = {}; Cu.import("resource://devtools/client/shared/browser-loader.js", BrowserLoaderModule); var { loader, require } = BrowserLoaderModule.BrowserLoader({ baseURI: "resource://devtools/client/netmonitor/", window }); const promise = require("promise"); const Services = require("Services"); +/* eslint-disable mozilla/reject-some-requires */ const {XPCOMUtils} = require("resource://gre/modules/XPCOMUtils.jsm"); const EventEmitter = require("devtools/shared/event-emitter"); const Editor = require("devtools/client/sourceeditor/editor"); const {TimelineFront} = require("devtools/shared/fronts/timeline"); const {Task} = require("devtools/shared/task"); const {Prefs} = require("./prefs"); const {EVENTS} = require("./events");
--- a/devtools/client/netmonitor/netmonitor-view.js +++ b/devtools/client/netmonitor/netmonitor-view.js @@ -7,17 +7,19 @@ /* globals Prefs, gNetwork, setInterval, setTimeout, clearInterval, clearTimeout, btoa */ /* exported $, $all */ "use strict"; XPCOMUtils.defineLazyGetter(this, "NetworkHelper", function () { return require("devtools/shared/webconsole/network-helper"); }); +/* eslint-disable mozilla/reject-some-requires */ const {VariablesView} = require("resource://devtools/client/shared/widgets/VariablesView.jsm"); +/* eslint-disable mozilla/reject-some-requires */ const {VariablesViewController} = require("resource://devtools/client/shared/widgets/VariablesViewController.jsm"); const {ToolSidebar} = require("devtools/client/framework/sidebar"); const {testing: isTesting} = require("devtools/shared/flags"); const {ViewHelpers, Heritage} = require("devtools/client/shared/widgets/view-helpers"); const {PluralForm} = require("devtools/shared/plural-form"); const {Filters} = require("./filter-predicates"); const {getFormDataSections, formDataURI,
--- a/devtools/client/netmonitor/request-utils.js +++ b/devtools/client/netmonitor/request-utils.js @@ -1,10 +1,10 @@ "use strict"; - +/* eslint-disable mozilla/reject-some-requires */ const { Ci } = require("chrome"); const { KeyCodes } = require("devtools/client/shared/keycodes"); const { Task } = require("devtools/shared/task"); const NetworkHelper = require("devtools/shared/webconsole/network-helper"); /** * Helper method to get a wrapped function which can be bound to as * an event listener directly and is executed only when data-key is
--- a/devtools/client/netmonitor/requests-menu-view.js +++ b/devtools/client/netmonitor/requests-menu-view.js @@ -1,16 +1,17 @@ /* globals document, window, dumpn, $, $all, gNetwork, EVENTS, Prefs, NetMonitorController, NetMonitorView */ "use strict"; - +/* eslint-disable mozilla/reject-some-requires */ const { Cc, Ci, Cu } = require("chrome"); const Services = require("Services"); const {Task} = require("devtools/shared/task"); const {DeferredTask} = Cu.import("resource://gre/modules/DeferredTask.jsm", {}); +/* eslint-disable mozilla/reject-some-requires */ const {SideMenuWidget} = require("resource://devtools/client/shared/widgets/SideMenuWidget.jsm"); const {HTMLTooltip} = require("devtools/client/shared/widgets/tooltip/HTMLTooltip"); const {setImageTooltip, getImageDimensions} = require("devtools/client/shared/widgets/tooltip/ImageTooltipHelper"); const {Heritage, WidgetMethods, setNamedTimeout} = require("devtools/client/shared/widgets/view-helpers"); const {gDevTools} = require("devtools/client/framework/devtools"); const {Curl, CurlUtils} = require("devtools/client/shared/curl");