Bug 1700509 [wpt PR 28201] - Update offsetParent behavior in shadow trees, a=testonly
authorJoey Arhar <jarhar@chromium.org>
Fri, 23 Apr 2021 10:17:30 +0000
changeset 577247 b03075225de2d2b53974bba8db7b0d5c326b3242
parent 577246 c981b467789021519b396d3c4ce2347d68996a49
child 577248 6bb5bc0af0694d01d625500eebd754cc91a69463
push id141827
push userwptsync@mozilla.com
push dateSat, 24 Apr 2021 02:11:12 +0000
treeherderautoland@3a7d9d49c316 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1700509, 28201, 239313, 1514074, 920069, 2775208, 872658
milestone90.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1700509 [wpt PR 28201] - Update offsetParent behavior in shadow trees, a=testonly Automatic update from web-platform-tests Update offsetParent behavior in shadow trees New behavior for offsetParent in shadow trees was discussed in [1] and [2]. This lead to a chromium patch [3] which changed the behavior. After [3] landed, the desired behavior in the discussions in [1] and [2] seemed to have changed. Unfortunately, the author of [3] was no longer working on chromium. This new behavior was then added to the spec and landed in webkit [4] and firefox [5], and a WPT was added for it [6]. This patch implements the new behavior to follow suit with webkit and firefox based on the WPT in [6]. Unfortunately, there are several tests which are either internal to chromium or are only passing in chromium which appear to oppose this new behavior and will have to be updated or removed: - external/wpt/css/css-contain/content-visibility/content-visibility-035.html - external/wpt/css/css-contain/content-visibility/content-visibility-044.html - fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html - shadow-dom/offsetParent.html For shadow-dom/offsetParent.html, I verified that firefox and safari both currently fail the same tests which this patch does. [1] https://github.com/WICG/webcomponents/issues/497 [2] https://github.com/w3c/csswg-drafts/issues/159 [3] https://chromium.googlesource.com/chromium/src/+/18d455ee833f6a30dcbe2755380861eb75cd9f6f [4] https://trac.webkit.org/changeset/239313/webkit [5] https://bugzilla.mozilla.org/show_bug.cgi?id=1514074 [6] https://wpt.fyi/results/shadow-dom/offsetParent-across-shadow-boundaries.html Fixed: 920069 Change-Id: I168edc5ad0e4fcb92d0c4a440623f2424b14a988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2775208 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#872658} -- wpt-commits: 8d8b8c4e2e42d07398fd5e98b541ee239e1d35a4 wpt-pr: 28201
testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-035.html
testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-044.html
--- a/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-035.html
+++ b/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-035.html
@@ -2,16 +2,18 @@
 <html>
 <meta charset="utf8">
 <title>Display Locking: hidden shadow descendant</title>
 <link rel="author" title="Rakina Zata Amni" href="mailto:rakina@chromium.org">
 <link rel="help" href="https://drafts.csswg.org/css-contain/#content-visibility">
 <meta name="assert" content="content-visibility hidden element's subtree cannot be focused">
 <meta name="assert" content="content-visibility hidden element's subtree can access layout values">
 
+<body style="margin: 0">
+
 <div id="host">
   <input id="slotted" type="text">
 </div>
 
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 
 <script>
--- a/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-044.html
+++ b/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-044.html
@@ -4,16 +4,18 @@
 <title>Content Visibility: slot moved after container is hidden</title>
 <link rel="author" title="Vladimir Levin" href="mailto:vmpstr@chromium.org">
 <link rel="help" href="https://drafts.csswg.org/css-contain/#content-visibility">
 <meta name="assert" content="ensure that hidden slotted element can be updated">
 
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 
+<body style="margin: 0">
+
 <div id=host>
 <input id=slotted>
 <script>
 
 async_test((t) => {
   let container = document.createElement("div");
   container.innerHTML = "<slot></slot>";
   let shadowRoot = host.attachShadow({ mode: "open" });