autoland: changeset 512242:a980e7ea9d0abfbbafb3bfce13cdf007affe99e0

author	Ian Kilpatrick <ikilpatrick@chromium.org>
	Wed, 29 Jan 2020 08:03:11 +0000
changeset 512242	a980e7ea9d0abfbbafb3bfce13cdf007affe99e0
parent 512241	9792cc515f27b053dd8a6640c7692e82a586524e
child 512243	c699426512a934eae65009c80ba18fb4ca13061f
push id	106279
push user	wptsync@mozilla.com
push date	Fri, 31 Jan 2020 20:44:12 +0000
treeherder	autoland@c5cd3d0d3741 [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	testonly
bugs	1608999, 21151, 1772524, 1040069, 1999224, 734856
milestone	74.0a1
first release with	nightly linux32 cd7d8aad0306 / 74.0a1 / 20200201092806 / files nightly linux64 cd7d8aad0306 / 74.0a1 / 20200201092806 / files nightly mac cd7d8aad0306 / 74.0a1 / 20200201092806 / files nightly win32 cd7d8aad0306 / 74.0a1 / 20200201092806 / files nightly win64 cd7d8aad0306 / 74.0a1 / 20200201092806 / files
last release without	nightly linux32 76ee1827c820 / 74.0a1 / 20200131213333 / files nightly linux64 76ee1827c820 / 74.0a1 / 20200131213333 / files nightly mac 76ee1827c820 / 74.0a1 / 20200131213333 / files nightly win32 76ee1827c820 / 74.0a1 / 20200131213333 / files nightly win64 76ee1827c820 / 74.0a1 / 20200131213333 / files

Bug 1608999 [wpt PR 21151] - [css-grid] Skip simplified layout if the Grid is dirty., a=testonly Automatic update from web-platform-tests [css-grid] Skip simplified layout if the Grid is dirty. Bug report bisected to an improvement in the LayoutNG OOF cache. https://chromium-review.googlesource.com/c/chromium/src/+/1772524 There was a larger underlying issue that a LayoutGrid could have simplified layout performed, while having a non-existent grid. This manifested in an incorrect paint output. This patch simply disables simplified-layout whenever there is dirty grid. It doesn't seem the invalidation for this grid data-structure is optimal. Bug: 1040069 Change-Id: I347630f3fc5c330ae57b06219d1e32b6269177d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999224 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#734856} -- wpt-commits: d0d42b1d9d37ceda3d5acb60edf4f157f06a4190 wpt-pr: 21151

testing/web-platform/tests/css/css-grid/chrome-bug-001.html

file | annotate | diff | comparison | revisions

new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-grid/chrome-bug-001.html
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<link rel="match" href="../reference/ref-filled-green-100px-square-only.html">
+<link rel="help" href="https://crbug.com/1040069">
+<meta name="assert" content="This test checks that a dynamic change relative position paints the grid correctly."/>
+<style>
+#target {
+  display: grid;
+  grid-template-columns: repeat(auto-fit, 50px);
+
+  position: relative;
+  top: 10px;
+}
+</style>
+<p>Test passes if there is a filled green square.</p>
+<div id="target">
+  <div style="width: 100px; height: 100px; background: green;"></div>
+</div>
+<script>
+document.body.offsetTop;
+document.getElementById('target').style.top = '0px';
+</script>