Bug 1425349 - Fix mozscreenshots logging where multiple log arguments were used. r=johannh
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Thu, 14 Dec 2017 16:34:39 -0600
changeset 396556 a8c870edc43dc60f36b4b7cab9dd5cb52e824341
parent 396555 78bd64f9ee0892690c7a62b1a6a14b2e2081454d
child 396557 fd98493f58fa4c5c9d55558c0d623fbc2ac9f3e6
push id57042
push usermozilla@noorenberghe.ca
push dateFri, 15 Dec 2017 17:07:49 +0000
treeherderautoland@a8c870edc43d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjohannh
bugs1425349
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1425349 - Fix mozscreenshots logging where multiple log arguments were used. r=johannh MozReview-Commit-ID: LW8vNkBYTGx
browser/tools/mozscreenshots/mozscreenshots/extension/TestRunner.jsm
--- a/browser/tools/mozscreenshots/mozscreenshots/extension/TestRunner.jsm
+++ b/browser/tools/mozscreenshots/mozscreenshots/extension/TestRunner.jsm
@@ -54,32 +54,32 @@ this.TestRunner = {
                    (new Date()).toISOString().replace(/:/g, "-") + "_" + Services.appinfo.OS];
     let screenshotPath = FileUtils.getFile("TmpD", subDirs).path;
 
     const MOZ_UPLOAD_DIR = env.get("MOZ_UPLOAD_DIR");
     if (MOZ_UPLOAD_DIR) {
       screenshotPath = MOZ_UPLOAD_DIR;
     }
 
-    this.mochitestScope.info("Saving screenshots to:", screenshotPath);
+    this.mochitestScope.info(`Saving screenshots to: ${screenshotPath}`);
 
     let screenshotPrefix = Services.appinfo.appBuildID;
     if (jobName) {
       screenshotPrefix += "-" + jobName;
     }
     screenshotPrefix += "_";
     Screenshot.init(screenshotPath, this._extensionPath, screenshotPrefix);
     this._libDir = this._extensionPath.QueryInterface(Ci.nsIFileURL).file.clone();
     this._libDir.append("chrome");
     this._libDir.append("mozscreenshots");
     this._libDir.append("lib");
 
     let sets = this.loadSets(setNames);
 
-    this.mochitestScope.info(sets.length + " sets:", setNames);
+    this.mochitestScope.info(`${sets.length} sets: ${setNames}`);
     this.combos = new LazyProduct(sets);
     this.mochitestScope.info(this.combos.length + " combinations");
 
     this.currentComboIndex = this.completedCombos = 0;
     this._lastCombo = null;
 
     // Setup some prefs
     Services.prefs.setCharPref("browser.aboutHomeSnippets.updateUrl",