Bug 1546783 - Stop speculatively trying to load <svg:style xlink:href>. r=bzbarsky
☠☠ backed out by 5f8f1210274a ☠ ☠
authorEmilio Cobos Álvarez <emilio@crisal.io>
Mon, 30 Sep 2019 10:37:24 +0000
changeset 495600 a8ac28c2bfc738cc1642efaf12bd40f0ee3ffec7
parent 495599 b2678d2e55fb58b4605020136deaea6c7cabf3e8
child 495601 ad3822105edc11bf15a3b36983db2870eb6cdb76
push id96713
push userealvarez@mozilla.com
push dateMon, 30 Sep 2019 13:19:51 +0000
treeherderautoland@ad3822105edc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbzbarsky
bugs1546783
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1546783 - Stop speculatively trying to load <svg:style xlink:href>. r=bzbarsky That doesn't make much sense to me. Differential Revision: https://phabricator.services.mozilla.com/D47470
parser/html/nsHtml5TreeBuilderCppSupplement.h
--- a/parser/html/nsHtml5TreeBuilderCppSupplement.h
+++ b/parser/html/nsHtml5TreeBuilderCppSupplement.h
@@ -357,29 +357,16 @@ nsIContentHandle* nsHtml5TreeBuilder::cr
               mOpQueue.AppendElement(mozilla::fallible);
           if (MOZ_UNLIKELY(!treeOp)) {
             MarkAsBrokenAndRequestSuspensionWithoutBuilder(
                 NS_ERROR_OUT_OF_MEMORY);
             return nullptr;
           }
           opSetStyleLineNumber operation(content, tokenizer->getLineNumber());
           treeOp->Init(mozilla::AsVariant(operation));
-
-          nsHtml5String url =
-              aAttributes->getValue(nsHtml5AttributeName::ATTR_XLINK_HREF);
-          if (url) {
-            nsHtml5String crossOrigin =
-                aAttributes->getValue(nsHtml5AttributeName::ATTR_CROSSORIGIN);
-            nsHtml5String integrity =
-                aAttributes->getValue(nsHtml5AttributeName::ATTR_INTEGRITY);
-            nsHtml5String referrerPolicy = aAttributes->getValue(
-                nsHtml5AttributeName::ATTR_REFERRERPOLICY);
-            mSpeculativeLoadQueue.AppendElement()->InitStyle(
-                url, nullptr, crossOrigin, referrerPolicy, integrity);
-          }
         }
         break;
     }
   } else if (aNamespace != kNameSpaceID_MathML) {
     // No speculative loader--just line numbers and defer/async check
     if (nsGkAtoms::style == aName) {
       nsHtml5TreeOperation* treeOp = mOpQueue.AppendElement(mozilla::fallible);
       if (MOZ_UNLIKELY(!treeOp)) {