Bug 1521929 - Remove the memory feature from profiler DevTools; r=canaltinova
authorGreg Tatum <gtatum@mozilla.com>
Mon, 05 Aug 2019 15:37:21 +0000
changeset 486249 a88ee42dec318b08c824019d58a37a71dde00e9a
parent 486248 49893566430d4b9e247d45abd48219ba1bd6bec6
child 486250 96b2970ebf26b20058b3a445498fb3af018dc145
push id91726
push usergtatum@mozilla.com
push dateMon, 05 Aug 2019 20:23:54 +0000
treeherderautoland@a88ee42dec31 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscanaltinova
bugs1521929
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521929 - Remove the memory feature from profiler DevTools; r=canaltinova Differential Revision: https://phabricator.services.mozilla.com/D40288
devtools/client/performance-new/components/Settings.js
devtools/client/performance-new/popup/background.jsm
devtools/client/performance-new/popup/popup.html
devtools/client/performance-new/popup/popup.js
devtools/server/tests/browser/browser_perf-04.js
--- a/devtools/client/performance-new/components/Settings.js
+++ b/devtools/client/performance-new/components/Settings.js
@@ -147,23 +147,16 @@ const featureCheckboxes = [
       "useful on platforms that do not support stack walking.",
   },
   {
     name: "Main Thread IO",
     value: "mainthreadio",
     title: "Record main thread I/O markers.",
   },
   {
-    name: "Memory",
-    value: "memory",
-    title:
-      "Add memory measurements to the samples, this includes resident set size " +
-      "(RSS) and unique set size (USS).",
-  },
-  {
     name: "Privacy",
     value: "privacy",
     title: "Remove some potentially user-identifiable information.",
   },
   {
     name: "Sequential Styling",
     value: "seqstyle",
     title: "Disable parallel traversal in styling.",
--- a/devtools/client/performance-new/popup/background.jsm
+++ b/devtools/client/performance-new/popup/background.jsm
@@ -232,17 +232,16 @@ function intializeState() {
     return storedState;
   }
 
   const features = {
     java: false,
     js: true,
     leaf: true,
     mainthreadio: false,
-    memory: false,
     privacy: false,
     responsiveness: true,
     screenshots: false,
     seqstyle: false,
     stackwalk: true,
     tasktracer: false,
     trackopts: false,
     jstracer: false,
--- a/devtools/client/performance-new/popup/popup.html
+++ b/devtools/client/performance-new/popup/popup.html
@@ -140,21 +140,16 @@
               id="perf-settings-feature-checkbox-screenshots" type="checkbox" value="screenshots" />
             <div class="perf-settings-feature-name">Screenshots</div>
             <div class="perf-settings-feature-title">Capture screenshots of browser windows.</div>
           </label><label class="perf-settings-checkbox-label perf-settings-feature-label"><input class="perf-settings-checkbox"
               id="perf-settings-feature-checkbox-mainthreadio" type="checkbox" value="mainthreadio" />
             <div class="perf-settings-feature-name">Main Thread IO</div>
             <div class="perf-settings-feature-title">Record main thread I/O markers.</div>
           </label><label class="perf-settings-checkbox-label perf-settings-feature-label"><input class="perf-settings-checkbox"
-              id="perf-settings-feature-checkbox-memory" type="checkbox" value="memory" />
-            <div class="perf-settings-feature-name">Memory</div>
-            <div class="perf-settings-feature-title">Add memory measurements to the samples, this includes resident set
-              size (RSS) and unique set size (USS).</div>
-          </label><label class="perf-settings-checkbox-label perf-settings-feature-label"><input class="perf-settings-checkbox"
               id="perf-settings-feature-checkbox-privacy" type="checkbox" value="privacy" />
             <div class="perf-settings-feature-name">Privacy</div>
             <div class="perf-settings-feature-title">Remove some potentially user-identifiable information.</div>
           </label><label class="perf-settings-checkbox-label perf-settings-feature-label"><input class="perf-settings-checkbox"
               id="perf-settings-feature-checkbox-seqstyle" type="checkbox" value="seqstyle" />
             <div class="perf-settings-feature-name">Sequential Styling</div>
             <div class="perf-settings-feature-title">Disable parallel traversal in styling.</div>
           </label><label class="perf-settings-checkbox-label perf-settings-feature-label"><input class="perf-settings-checkbox"
--- a/devtools/client/performance-new/popup/popup.js
+++ b/devtools/client/performance-new/popup/popup.js
@@ -20,17 +20,16 @@ const windowLengthScale = makeExponentia
 const PROFILE_ENTRY_SIZE = 9; // sizeof(double) + sizeof(char), http://searchfox.org/mozilla-central/rev/e8835f52eff29772a57dca7bcc86a9a312a23729/tools/profiler/core/ProfileEntry.h#73
 
 const featurePrefix = "perf-settings-feature-checkbox-";
 const features = [
   "java",
   "js",
   "leaf",
   "mainthreadio",
-  "memory",
   "privacy",
   "responsiveness",
   "screenshots",
   "seqstyle",
   "stackwalk",
   "tasktracer",
   "jstracer",
   "jsallocations",
--- a/devtools/server/tests/browser/browser_perf-04.js
+++ b/devtools/server/tests/browser/browser_perf-04.js
@@ -20,17 +20,17 @@ add_task(async function() {
     false,
     "The browser is not in private browsing mode."
   );
   is(await front.isActive(), false, "The profiler is not active yet.");
 
   front.once("profiler-started", (entries, interval, features, duration) => {
     is(entries, 1024, "Should apply entries by startProfiler");
     is(interval, 0.1, "Should apply interval by startProfiler");
-    is(features, 0x202, "Should apply features by startProfiler");
+    is(typeof features, "number", "Should apply features by startProfiler");
     is(duration, 2, "Should apply duration by startProfiler");
   });
 
   // Start the profiler.
   await front.startProfiler({
     entries: 1000,
     duration: 2,
     interval: 0.1,