Bug 1393274: Correct webpage RTL padding/margins. r=liuche
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 30 Aug 2017 13:27:20 -0700
changeset 378036 a1a1f209f8256e0a9742805d9d832e322b7e5b25
parent 378035 2a39f7aa9629f1871d5ce205093419f1dcc73fa0
child 378037 63b87e31320db96a4af189dfcd468f8134ae1ebd
push id50163
push usermichael.l.comella@gmail.com
push dateThu, 31 Aug 2017 20:10:45 +0000
treeherderautoland@63b87e31320d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersliuche
bugs1393274
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1393274: Correct webpage RTL padding/margins. r=liuche Previously, I added a comment to explain why the explicit 0dp padding/margins are necessary for RTL but since it's required everywhere padding/margins are used, it's unsustainable and I chose not to do it here. MozReview-Commit-ID: H7H9xgeLy8b
mobile/android/app/src/main/res/layout/activity_stream_webpage_item_row.xml
--- a/mobile/android/app/src/main/res/layout/activity_stream_webpage_item_row.xml
+++ b/mobile/android/app/src/main/res/layout/activity_stream_webpage_item_row.xml
@@ -50,16 +50,18 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_toEndOf="@id/icon_wrapper"
         android:layout_toLeftOf="@id/menu"
         android:layout_toRightOf="@id/icon_wrapper"
         android:layout_toStartOf="@id/menu"
         android:paddingLeft="@dimen/activity_stream_base_margin"
         android:paddingStart="@dimen/activity_stream_base_margin"
+        android:paddingRight="0dp"
+        android:paddingEnd="0dp"
         android:paddingTop="@dimen/activity_stream_base_margin"
         android:textAlignment="viewStart"
         android:textColor="@color/activity_stream_subtitle"
         android:textSize="12sp"
         tools:text="twitter" />
 
     <!-- See id/page_domain for textAlignment comment. -->
     <TextView
@@ -70,16 +72,18 @@
         android:layout_toEndOf="@id/icon_wrapper"
         android:layout_toLeftOf="@id/menu"
         android:layout_toRightOf="@id/icon_wrapper"
         android:layout_toStartOf="@id/menu"
         android:ellipsize="end"
         android:maxLines="3"
         android:paddingLeft="@dimen/activity_stream_base_margin"
         android:paddingStart="@dimen/activity_stream_base_margin"
+        android:paddingRight="0dp"
+        android:paddingEnd="0dp"
         android:textAlignment="viewStart"
         android:textColor="#ff000000"
         android:textSize="14sp"
         android:textStyle="bold"
         tools:text="Descriptive title of a page that is veeeeeeery long - maybe even too long?" />
 
     <LinearLayout
         android:layout_width="match_parent"
@@ -104,17 +108,20 @@
             android:layout_height="12dp"
             tools:src="@drawable/ic_as_bookmarked" />
 
         <!-- See id/page_domain for textAlignment comment. -->
         <TextView
             android:id="@+id/page_source"
             android:layout_width="0dp"
             android:layout_height="wrap_content"
+            android:layout_marginStart="2dp"
             android:layout_marginLeft="2dp"
+            android:layout_marginRight="0dp"
+            android:layout_marginEnd="0dp"
             android:layout_weight="1"
             android:textAlignment="viewStart"
             android:textColor="@color/activity_stream_subtitle"
             android:textSize="12sp"
             tools:text="Bookmarked" />
 
     </LinearLayout>
 </RelativeLayout>