Bug 1706496 - Fix proton checkbox styles for HCM. r=Gijs
authorEmilio Cobos Álvarez <emilio@crisal.io>
Wed, 21 Apr 2021 13:42:41 +0000
changeset 576961 a016a1cc626e602314b544bff3a9608b8eb5831b
parent 576960 593396efa9385dc05a072be49ed6bceda05efdf1
child 576962 d58302f7861652018f37c8ff232f9595789aa2d0
push id141644
push userealvarez@mozilla.com
push dateWed, 21 Apr 2021 14:59:13 +0000
treeherderautoland@a016a1cc626e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1706496
milestone90.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1706496 - Fix proton checkbox styles for HCM. r=Gijs Specifying a system color foreground with a non-system-color background is not good. Differential Revision: https://phabricator.services.mozilla.com/D112910
toolkit/themes/shared/checkbox.inc.css
--- a/toolkit/themes/shared/checkbox.inc.css
+++ b/toolkit/themes/shared/checkbox.inc.css
@@ -27,20 +27,20 @@ checkbox[disabled="true"] {
 }
 
 /* ::::: checkmark image ::::: */
 
 .checkbox-check {
   appearance: none;
   height: 16px;
   width: 16px;
-  border: 1px solid var(--checkbox-border-color, ThreeDDarkShadow);
+  color: var(--checkbox-border-color, ThreeDDarkShadow);
   background-color: var(--checkbox-unchecked-bgcolor, Field);
+  border: 1px solid currentColor;
   border-radius: 2px;
-  color: FieldText;
   margin-inline-end: 6px;
 }
 
 checkbox:not([disabled="true"]):hover > .checkbox-check {
   background-color: var(--checkbox-unchecked-hover-bgcolor, color-mix(in srgb, -moz-accent-color 4%, Field));
 }
 
 checkbox:not([disabled="true"]):hover:active > .checkbox-check {