Bug 1371676 - Improve Sync Notification Titles r=eoger
authorJeongkyu Kim <jeongkyu.kim@gmail.com>
Tue, 13 Jun 2017 21:26:58 +0900
changeset 364113 9fab569b6389
parent 364112 29d5b5f6514c
child 364114 7243e9c89663
push id44814
push usereoger@mozilla.com
push dateThu, 15 Jun 2017 16:50:59 +0000
treeherderautoland@9fab569b6389 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerseoger
bugs1371676
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1371676 - Improve Sync Notification Titles r=eoger MozReview-Commit-ID: 5SZJpicDuXC
browser/components/nsBrowserGlue.js
browser/locales/en-US/chrome/browser/accounts.properties
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -2248,17 +2248,17 @@ BrowserGlue.prototype = {
         }
         // Use the page URL as the body. We strip the fragment and query to
         // reduce size, and also format it the same way that the url bar would.
         body = URIs[0].uri.replace(/[?#].*$/, "");
         if (win.gURLBar) {
           body = win.gURLBar.trimValue(body);
         }
       } else {
-        title = bundle.GetStringFromName("tabsArrivingNotification.title");
+        title = bundle.GetStringFromName("multipleTabsArrivingNotification.title");
         const allSameDevice = URIs.every(URI => URI.clientId == URIs[0].clientId);
         const unknownDevice = allSameDevice && !deviceName;
         let tabArrivingBody;
         if (unknownDevice) {
           tabArrivingBody = "unnamedTabsArrivingNotificationNoDevice.body";
         } else if (allSameDevice) {
           tabArrivingBody = "unnamedTabsArrivingNotification2.body";
         } else {
--- a/browser/locales/en-US/chrome/browser/accounts.properties
+++ b/browser/locales/en-US/chrome/browser/accounts.properties
@@ -27,35 +27,35 @@ deviceConnectedBody.noDeviceName = This 
 # LOCALIZATION NOTE (syncStartNotification.title, syncStartNotification.body)
 # These strings are used in a notification shown after Sync is connected.
 syncStartNotification.title = Sync Enabled
 # %S is brandShortName
 syncStartNotification.body2 = %S will begin syncing momentarily.
 
 # LOCALIZATION NOTE (deviceDisconnectedNotification.title, deviceDisconnectedNotification.body)
 # These strings are used in a notification shown after Sync was disconnected remotely.
-deviceDisconnectedNotification.title = Sync disconnected
+deviceDisconnectedNotification.title = Sync Disconnected
 deviceDisconnectedNotification.body = This computer has been successfully disconnected from Firefox Sync.
 
 # LOCALIZATION NOTE (sendToAllDevices.menuitem)
 # Displayed in the Send Tab/Page/Link to Device context menu when right clicking a tab, a page or a link.
 sendToAllDevices.menuitem = Send to All Devices
 
 # LOCALIZATION NOTE (tabArrivingNotification.title, tabArrivingNotificationWithDevice.title,
-# tabsArrivingNotification.title, unnamedTabsArrivingNotification2.body,
+# multipleTabsArrivingNotification.title, unnamedTabsArrivingNotification2.body,
 # unnamedTabsArrivingNotificationMultiple2.body, unnamedTabsArrivingNotificationNoDevice.body)
 # These strings are used in a notification shown when we're opening tab(s) another device sent us to display.
 
 # LOCALIZATION NOTE (tabArrivingNotification.title, tabArrivingNotificationWithDevice.title)
 # The body for these is the URL of the tab recieved
-tabArrivingNotification.title = Tab received
+tabArrivingNotification.title = Tab Received
 # LOCALIZATION NOTE (tabArrivingNotificationWithDevice.title) %S is the device name
 tabArrivingNotificationWithDevice.title = Tab from %S
 
-tabsArrivingNotification.title = Multiple tabs received
+multipleTabsArrivingNotification.title = Tabs Received
 # LOCALIZATION NOTE (unnamedTabsArrivingNotification2.body):
 # Semi-colon list of plural forms.
 # See: http://developer.mozilla.org/en/docs/Localization_and_Plurals
 # #1 is the number of tabs received and #2 is the device name.
 unnamedTabsArrivingNotification2.body = #1 tab has arrived from #2;#1 tabs have arrived from #2
 # LOCALIZATION NOTE (unnamedTabsArrivingNotificationMultiple2.body):
 # Semi-colon list of plural forms.
 # See: http://developer.mozilla.org/en/docs/Localization_and_Plurals