Backed out changeset 7c5a7b0b6bc6 (bug 1465424) for bustages in /builds/worker/checkouts/gecko/js/src/devtools/rootAnalysis/run_complete on a CLOSED TREE
authorshindli <shindli@mozilla.com>
Fri, 06 Jul 2018 16:39:55 +0300
changeset 425336 9cfad7403969ede7c51c175a18cfeaa8e98f3a6e
parent 425335 7c5a7b0b6bc6123e774c8527c1a3cc5448b9fc12
child 425337 a8263446f439ee8f6f14ad8867ae4a0ab8184c4b
push id66040
push usershindli@mozilla.com
push dateFri, 06 Jul 2018 13:40:11 +0000
treeherderautoland@9cfad7403969 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1465424
milestone63.0a1
backs out7c5a7b0b6bc6123e774c8527c1a3cc5448b9fc12
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 7c5a7b0b6bc6 (bug 1465424) for bustages in /builds/worker/checkouts/gecko/js/src/devtools/rootAnalysis/run_complete on a CLOSED TREE
devtools/client/inspector/fonts/fonts.js
toolkit/components/telemetry/Histograms.json
--- a/devtools/client/inspector/fonts/fonts.js
+++ b/devtools/client/inspector/fonts/fonts.js
@@ -49,20 +49,16 @@ const REGISTERED_AXES_TO_FONT_PROPERTIES
   "ital": "font-style",
   "opsz": "font-optical-sizing",
   "slnt": "font-style",
   "wdth": "font-stretch",
   "wght": "font-weight",
 };
 const REGISTERED_AXES = Object.keys(REGISTERED_AXES_TO_FONT_PROPERTIES);
 
-const HISTOGRAM_N_FONT_AXES = "DEVTOOLS_FONTEDITOR_N_FONT_AXES";
-const HISTOGRAM_N_FONTS_RENDERED = "DEVTOOLS_FONTEDITOR_N_FONTS_RENDERED";
-const HISTOGRAM_FONT_TYPE_DISPLAYED = "DEVTOOLS_FONTEDITOR_FONT_TYPE_DISPLAYED";
-
 class FontInspector {
   constructor(inspector, window) {
     this.cssProperties = getCssProperties(inspector.toolbox);
     this.document = window.document;
     this.inspector = inspector;
     // Set of unique keyword values supported by designated font properties.
     this.keywordValues = new Set(this.getFontPropertyValueKeywords());
     this.nodeComputedStyle = {};
@@ -464,42 +460,16 @@ class FontInspector {
   isSelectedNodeValid() {
     return this.inspector &&
            this.inspector.selection.nodeFront &&
            this.inspector.selection.isConnected() &&
            this.inspector.selection.isElementNode();
   }
 
   /**
-   * Upon a new node selection, log some interesting telemetry probes.
-   */
-  logTelemetryProbesOnNewNode() {
-    const { fontData, fontEditor } = this.store.getState();
-    const { telemetry } = this.inspector;
-
-    // Log the number of font faces used to render content of the element.
-    const nbOfFontsRendered = fontData.fonts.length;
-    telemetry.getHistogramById(HISTOGRAM_N_FONTS_RENDERED).add(nbOfFontsRendered);
-
-    // Log data about the currently edited font (if any).
-    // Note that the edited font is always the first one from the fontEditor.fonts array.
-    const editedFont = fontEditor.fonts[0];
-    if (!editedFont) {
-      return;
-    }
-
-    const nbOfAxes = editedFont.variationAxes ? editedFont.variationAxes.length : 0;
-    telemetry.getHistogramById(HISTOGRAM_FONT_TYPE_DISPLAYED).add(
-      !nbOfAxes ? "non-variable" : "variable");
-    if (nbOfAxes) {
-      telemetry.getHistogramById(HISTOGRAM_N_FONT_AXES).add(nbOfAxes);
-    }
-  }
-
-  /**
    * Sync the Rule view with the latest styles from the page. Called in a debounced way
    * (see constructor) after property changes are applied directly to the CSS style rule
    * on the page circumventing direct TextProperty.setValue() which triggers expensive DOM
    * operations in TextPropertyEditor.update().
    *
    * @param  {String} name
    *         CSS property name
    * @param  {String} value
@@ -567,19 +537,18 @@ class FontInspector {
   }
 
   /**
    * Selection 'new-node' event handler.
    */
   onNewNode() {
     this.ruleView.off("property-value-updated", this.onRulePropertyUpdated);
     if (this.isPanelVisible()) {
-      Promise.all([this.update(), this.refreshFontEditor()]).then(() => {
-        this.logTelemetryProbesOnNewNode();
-      }).catch(e => console.error(e));
+      this.update();
+      this.refreshFontEditor();
     }
   }
 
   /**
    * Handler for change in preview input.
    */
   onPreviewFonts(value) {
     this.store.dispatch(updatePreviewText(value));
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -10165,48 +10165,16 @@
     "expires_in_version": "never",
     "kind": "linear",
     "high": 30,
     "n_buckets": 29,
     "bug_numbers": [1373483],
     "description": "On page load, record the number of CSS Grid elements present on a page when the DevTools is open",
     "releaseChannelCollection": "opt-out"
   },
-  "DEVTOOLS_FONTEDITOR_N_FONT_AXES": {
-    "record_in_processes": ["main"],
-    "alert_emails": ["dev-developer-tools@lists.mozilla.org", "mbalfanz@mozilla.com"],
-    "expires_in_version": "66",
-    "bug_numbers": [1465424],
-    "description": "Indicates the number of variation axes of the variable fonts that are displayed in the font editor UI",
-    "releaseChannelCollection": "opt-out",
-    "kind": "exponential",
-    "high": 100,
-    "n_buckets": 20
-  },
-  "DEVTOOLS_FONTEDITOR_N_FONTS_RENDERED": {
-    "record_in_processes": ["main"],
-    "alert_emails": ["dev-developer-tools@lists.mozilla.org", "mbalfanz@mozilla.com"],
-    "expires_in_version": "66",
-    "bug_numbers": [1465424],
-    "description": "Indicates how many fonts the font editor displayed as being needed to render the selected element's content",
-    "releaseChannelCollection": "opt-out",
-    "kind": "exponential",
-    "high": 50,
-    "n_buckets": 10
-  },
-  "DEVTOOLS_FONTEDITOR_FONT_TYPE_DISPLAYED": {
-    "record_in_processes": ["main"],
-    "alert_emails": ["dev-developer-tools@lists.mozilla.org", "mbalfanz@mozilla.com"],
-    "expires_in_version": "66",
-    "bug_numbers": [1465424],
-    "description": "Indicates if the font editor displayed its UI for a non-variable font or a variable font",
-    "releaseChannelCollection": "opt-out",
-    "kind": "categorical",
-    "n_values": ["variable", "non-variable"]
-  },
   "BROWSER_IS_USER_DEFAULT": {
     "record_in_processes": ["main"],
     "expires_in_version": "never",
     "kind": "boolean",
     "releaseChannelCollection": "opt-out",
     "description": "The result of the startup default desktop browser check."
   },
   "BROWSER_IS_USER_DEFAULT_ERROR": {