Bug 1390420 - Implement new empty screen in private tabs panel. r=nechen,walkingice
authorJing-wei Wu <topwu.tw@gmail.com>
Tue, 15 Aug 2017 14:15:27 +0800
changeset 375009 9c4984d5e678e3628c3c2b96c5a05df64c115f91
parent 375008 b4e43c6fdf215c97f613bdc2660c16dd0068d463
child 375010 cf750e1140c597637f327459b058d84d445b4222
push id48901
push userryanvm@gmail.com
push dateWed, 16 Aug 2017 11:34:32 +0000
treeherderautoland@9c4984d5e678 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnechen, walkingice
bugs1390420
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1390420 - Implement new empty screen in private tabs panel. r=nechen,walkingice The new design removes the raccoon icon. MozReview-Commit-ID: AUv3xWA8Ic3
mobile/android/app/src/photon/res/drawable-hdpi/private_illustration_android.png
mobile/android/app/src/photon/res/drawable-mdpi/private_illustration_android.png
mobile/android/app/src/photon/res/drawable-xhdpi/private_illustration_android.png
mobile/android/app/src/photon/res/drawable-xxhdpi/private_illustration_android.png
mobile/android/app/src/photon/res/drawable-xxxhdpi/private_illustration_android.png
mobile/android/app/src/photon/res/layout/private_tabs_panel.xml
mobile/android/app/src/photon/res/values-large/styles.xml
mobile/android/app/src/photon/res/values/styles.xml
deleted file mode 100755
index cca9b03ade1b7a27e1e0f7f76af15d225fa3e9e1..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100755
index 2ce3c39fe8e7dc1f7865ca5f422035cae7d55e4e..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100755
index 38bc4d4ed221e3b8bb356b8323c8b98ae94b0c7f..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100755
index bd19044561106f3eb457036d84b8554e892fda0a..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100755
index 468b5bc1a96eb15431f2c1939723d023e9c00fbb..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
--- a/mobile/android/app/src/photon/res/layout/private_tabs_panel.xml
+++ b/mobile/android/app/src/photon/res/layout/private_tabs_panel.xml
@@ -17,22 +17,16 @@
         android:scrollbars="none">
 
         <LinearLayout
             android:id="@+id/private_tabs_empty"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:orientation="vertical">
 
-            <ImageView
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:layout_gravity="center_horizontal"
-                android:src="@drawable/private_illustration_android"/>
-
             <TextView
                 style="@style/TextAppearance.PrivateTab.Title"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_gravity="center_horizontal"
                 android:lineSpacingMultiplier="1.2"
                 android:gravity="center_horizontal"
                 android:text="@string/private_tab_panel_title"
@@ -40,28 +34,28 @@
 
             <TextView
                 style="@style/TextAppearance.PrivateTab.Description"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_gravity="center_horizontal"
                 android:layout_marginBottom="16dp"
                 android:gravity="center_horizontal"
-                android:lineSpacingMultiplier="1.4"
+                android:lineSpacingMultiplier="1.3"
                 android:text="@string/private_tab_panel_description"
                 android:textColor="@color/photon_text_secondary"/>
 
             <TextView
                 style="@style/TextAppearance.PrivateTab.Description"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_gravity="center_horizontal"
                 android:layout_marginBottom="36dp"
                 android:gravity="center_horizontal"
-                android:lineSpacingMultiplier="1.4"
+                android:lineSpacingMultiplier="1.3"
                 android:text="@string/private_tab_panel_description2"
                 android:textColor="@color/photon_text_secondary"/>
 
             <TextView
                 style="@style/TextAppearance.PrivateTab.Description"
                 android:id="@+id/learn_more_link"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
--- a/mobile/android/app/src/photon/res/values-large/styles.xml
+++ b/mobile/android/app/src/photon/res/values-large/styles.xml
@@ -84,17 +84,16 @@
 
     <style name="TextAppearance.UrlBar.Title" parent="TextAppearance.Medium">
         <item name="android:textSize">16sp</item>
     </style>
 
     <style name="TextAppearance.PrivateTab.Title" parent="TextAppearance.Large">
         <item name="android:textSize">26sp</item>
         <item name="android:maxWidth">300dp</item>
-        <item name="android:layout_marginTop">21dp</item>
         <item name="android:layout_marginBottom">16dp</item>
     </style>
 
     <style name="TextAppearance.PrivateTab.Description" parent="TextAppearance.Medium">
         <item name="android:maxWidth">398dp</item>
     </style>
 
     <style name="UrlBar.Base" />
--- a/mobile/android/app/src/photon/res/values/styles.xml
+++ b/mobile/android/app/src/photon/res/values/styles.xml
@@ -432,17 +432,16 @@
         <item name="android:textSize">16sp</item>
     </style>
 
     <style name="TextAppearance.SearchSuggestion" parent="TextAppearance.Small"/>
 
     <style name="TextAppearance.PrivateTab.Title" parent="TextAppearance.Large">
         <item name="android:textSize">20sp</item>
         <item name="android:maxWidth">200dp</item>
-        <item name="android:layout_marginTop">16dp</item>
         <item name="android:layout_marginBottom">16dp</item>
     </style>
 
     <style name="TextAppearance.PrivateTab.Description" parent="TextAppearance.Small">
         <item name="android:maxWidth">265dp</item>
     </style>
 
     <!-- BrowserToolbar -->