author | Tom Ritter <tom@mozilla.com> |
Thu, 03 Oct 2019 15:44:36 +0000 | |
changeset 496212 | 9bb8a933334ca990dfc5d914f9a95454166eb304 |
parent 496211 | 97f48d8b40a6f7e24fa045e846d212ae4ae9c9b8 |
child 496213 | 1cfb94153f548ea78f67e65478d6df36ecbfc14b |
push id | 97099 |
push user | tritter@mozilla.com |
push date | Thu, 03 Oct 2019 16:38:36 +0000 |
treeherder | autoland@9bb8a933334c [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | nalexander |
bugs | 1577521 |
milestone | 71.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
js/src/old-configure.in | file | annotate | diff | comparison | revisions | |
old-configure.in | file | annotate | diff | comparison | revisions |
--- a/js/src/old-configure.in +++ b/js/src/old-configure.in @@ -522,33 +522,33 @@ case "$target" in ;; esac ;; *-mingw*) DSO_CFLAGS= DSO_PIC_CFLAGS= if test -n "$GNU_CC" -o -n "$CLANG_CC"; then + # $GNU_CC will match gcc and clang; while $CLANG_CC will match only clang + if test -z "$CLANG_CC"; then + AC_MSG_ERROR(Firefox cannot be built with mingw-gcc and requires a mingw-clang toolchain to work) + fi + CC="$CC -mwindows" CXX="$CXX -mwindows" CPP="$CPP -mwindows" DSO_LDOPTS='-shared' # Use temp file for windres (bug 213281) RCFLAGS='-O coff --use-temp-file' # mingw doesn't require kernel32, user32, and advapi32 explicitly LIBS="$LIBS -lusp10 -lgdi32 -lwinmm -lwsock32" MOZ_FIX_LINK_PATHS= - if test -z "$CLANG_CC"; then - # Use static libgcc and libstdc++ - LDFLAGS="$LDFLAGS -static" - else - # Silence problematic clang warnings - CXXFLAGS="$CXXFLAGS -Wno-incompatible-ms-struct" - fi + # Silence problematic clang warnings + CXXFLAGS="$CXXFLAGS -Wno-incompatible-ms-struct" MOZ_OPTIMIZE_FLAGS="-O2" WIN32_CONSOLE_EXE_LDFLAGS=-mconsole WIN32_GUI_EXE_LDFLAGS=-mwindows else TARGET_COMPILER_ABI=msvc RANLIB='echo not_ranlib'
--- a/old-configure.in +++ b/old-configure.in @@ -640,44 +640,38 @@ case "$target" in esac ;; *-mingw*) DSO_CFLAGS= DSO_PIC_CFLAGS= # certain versions of cygwin's makedepend barf on the # #include <string> vs -I./dist/include/string issue so don't use it if test -n "$GNU_CC" -o -n "$CLANG_CC"; then + # $GNU_CC will match gcc and clang; while $CLANG_CC will match only clang + if test -z "$CLANG_CC"; then + AC_MSG_ERROR(Firefox cannot be built with mingw-gcc and requires a mingw-clang toolchain to work) + fi + CC="$CC -mwindows" CXX="$CXX -mwindows" CPP="$CPP -mwindows" DSO_LDOPTS='-shared' # Use temp file for windres (bug 213281) RCFLAGS='-O coff --use-temp-file' # mingw doesn't require kernel32, user32, and advapi32 explicitly LIBS="$LIBS -luuid -lusp10 -lgdi32 -lwinmm -lwsock32 -luserenv -lsecur32" MOZ_FIX_LINK_PATHS= MOZ_OPTIMIZE_FLAGS="-O2" WIN32_CONSOLE_EXE_LDFLAGS=-mconsole WIN32_GUI_EXE_LDFLAGS=-mwindows - if test -z "$CLANG_CC"; then - # Use static libgcc and libstdc++ - LDFLAGS="$LDFLAGS -static" - - # GCC/binutils can't link to a function if we try to include dllexport function - # in the same library as dllimport caller. To work around it, we build NSPR - # and NSS with -mnop-fun-dllimport flag. The drawback of this solution is that - # function thunks need to be generated for cross-DLL calls. - MOZ_FOLD_LIBS_FLAGS="-mnop-fun-dllimport" - else - # Silence problematic clang warnings - CXXFLAGS="$CXXFLAGS -Wno-incompatible-ms-struct" - fi + # Silence problematic clang warnings + CXXFLAGS="$CXXFLAGS -Wno-incompatible-ms-struct" else TARGET_COMPILER_ABI=msvc RANLIB='echo not_ranlib' STRIP='echo not_strip' PKG_SKIP_STRIP=1 # aarch64 doesn't support subsystems below 6.02 if test "$CPU_ARCH" = "aarch64"; then WIN32_SUBSYSTEM_VERSION=6.02