Bug 1440383 - Remove XBL accessibility role="xul:pane" and role="none" r=surkov
☠☠ backed out by fb9c7930fe77 ☠ ☠
authorTimothy Guan-tin Chien <timdream@gmail.com>
Wed, 28 Feb 2018 13:09:29 -0800
changeset 405887 9ac28273f15668650e2cb09d085ce4a75e87c844
parent 405886 940b93518f531af9a1d9a1f24139f87426634968
child 405888 95b662a55a1eaebe188858b96bdd21baab96da5b
push id60389
push usertimdream@gmail.com
push dateThu, 01 Mar 2018 00:49:22 +0000
treeherderautoland@9ac28273f156 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssurkov
bugs1440383
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1440383 - Remove XBL accessibility role="xul:pane" and role="none" r=surkov MozReview-Commit-ID: GJ0aouAzS77
accessible/base/nsAccessibilityService.cpp
--- a/accessible/base/nsAccessibilityService.cpp
+++ b/accessible/base/nsAccessibilityService.cpp
@@ -1467,17 +1467,17 @@ nsAccessibilityService::Shutdown()
 }
 
 already_AddRefed<Accessible>
 nsAccessibilityService::CreateAccessibleByType(nsIContent* aContent,
                                                DocAccessible* aDoc)
 {
   nsAutoString role;
   nsCoreUtils::XBLBindingRole(aContent, role);
-  if (role.IsEmpty() || role.EqualsLiteral("none"))
+  if (role.IsEmpty())
     return nullptr;
 
   RefPtr<Accessible> accessible;
 #ifdef MOZ_XUL
   // XUL controls
   if (role.EqualsLiteral("xul:colorpicker")) {
     accessible = new XULColorPickerAccessible(aContent, aDoc);