Bug 1462308 - Disable all Device Sensor events except orientation by default for stable. r=bkelly
authorJonathan Kingston <jkt@mozilla.com>
Thu, 17 May 2018 12:12:03 +0100
changeset 418789 98a2883d96406416da7186e53e66cf3ba51fc241
parent 418788 56396f687c8ef74ebfc0a90f9f065e593953d69e
child 418790 927fe2d0a4b9efd5e795534b8b612377de7ae50a
push id64149
push userjkingston@mozilla.com
push dateThu, 17 May 2018 22:41:50 +0000
treeherderautoland@98a2883d9640 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbkelly
bugs1462308
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1462308 - Disable all Device Sensor events except orientation by default for stable. r=bkelly MozReview-Commit-ID: 1PTWYpUP14
dom/tests/mochitest/general/test_interfaces.js
modules/libpref/init/all.js
--- a/dom/tests/mochitest/general/test_interfaces.js
+++ b/dom/tests/mochitest/general/test_interfaces.js
@@ -280,23 +280,23 @@ var interfaceNamesInGlobalScope =
     {name: "DataTransfer", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "DataTransferItem", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "DataTransferItemList", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "DelayNode", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
-    {name: "DeviceLightEvent", insecureContext: true, disabled: isEarlyBetaOrEarlier},
+    {name: "DeviceLightEvent", insecureContext: true, disabled: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "DeviceMotionEvent", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "DeviceOrientationEvent", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
-    {name: "DeviceProximityEvent", insecureContext: true, disabled: isEarlyBetaOrEarlier},
+    {name: "DeviceProximityEvent", insecureContext: true, disabled: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "Directory", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "Document", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "DocumentFragment", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "DocumentTimeline", insecureContext: true, release: false},
@@ -1140,17 +1140,17 @@ var interfaceNamesInGlobalScope =
     {name: "U2F", insecureContext: true, disabled: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "UIEvent", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "URL", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "URLSearchParams", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
-    {name: "UserProximityEvent", insecureContext: true, disabled: isEarlyBetaOrEarlier},
+    {name: "UserProximityEvent", insecureContext: true, disabled: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "ValidityState", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "VideoPlaybackQuality", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "VideoStreamTrack", insecureContext: true},
 // IMPORTANT: Do not change this list without review from a DOM peer!
     {name: "VRDisplay", insecureContext: true, releaseNonWindows: false},
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -4878,23 +4878,18 @@ pref("geo.enabled", true);
 
 // Timeout for outbound network geolocation provider XHR
 pref("geo.wifi.xhr.timeout", 60000);
 
 // Enable/Disable the various sensor APIs for content
 pref("device.sensors.enabled", true);
 pref("device.sensors.orientation.enabled", true);
 pref("device.sensors.motion.enabled", true);
-#ifdef EARLY_BETA_OR_EARLIER
 pref("device.sensors.proximity.enabled", false);
 pref("device.sensors.ambientLight.enabled", false);
-#else
-pref("device.sensors.proximity.enabled", true);
-pref("device.sensors.ambientLight.enabled", true);
-#endif
 
 // Enable/Disable the device storage API for content
 pref("device.storage.enabled", false);
 
 // Push/Pop/Replace State prefs
 pref("browser.history.maxStateObjectSize", 655360);
 
 pref("browser.meta_refresh_when_inactive.disabled", false);