Bug 1585747 - Remove devtools preference devtools.toolbox.content-frame r=ochameau
☠☠ backed out by ed16b88db27e ☠ ☠
authorJulian Descottes <jdescottes@mozilla.com>
Thu, 03 Oct 2019 15:15:49 +0000
changeset 496282 97efcd0fa370b81345f54b1c85da75c42d59aedb
parent 496281 b50de96607f422c1b7a41ed3d5f43635747addfb
child 496283 c211bfbf59b2f1fe421619c818888319d38bf2bc
push id97153
push userjdescottes@mozilla.com
push dateFri, 04 Oct 2019 07:04:25 +0000
treeherderautoland@c211bfbf59b2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersochameau
bugs1585747
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1585747 - Remove devtools preference devtools.toolbox.content-frame r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D47963
browser/app/profile/firefox.js
devtools/client/framework/toolbox-hosts.js
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -2352,17 +2352,10 @@ pref("devtools.aboutdebugging.collapsibi
 // Map top-level await expressions in the console
 pref("devtools.debugger.features.map-await-expression", true);
 
 // Disable autohide for DevTools popups and tooltips.
 // This is currently not exposed by any UI to avoid making
 // about:devtools-toolbox tabs unusable by mistake.
 pref("devtools.popup.disable_autohide", false);
 
-// Load the DevTools toolbox in a frame with type=content instead of type=chrome
-// See Bug 1539979 for more details.
-// We keep the option of running devtools in a chrome frame while we fix racy
-// tests that started failing when using type=content, but this ultimately
-// should be removed.
-pref("devtools.toolbox.content-frame", true);
-
 // FirstStartup service time-out in ms
 pref("first-startup.timeout", 30000);
--- a/devtools/client/framework/toolbox-hosts.js
+++ b/devtools/client/framework/toolbox-hosts.js
@@ -432,19 +432,17 @@ function focusTab(tab) {
 
 /**
  * Create an iframe that can be used to load DevTools via about:devtools-toolbox.
  */
 function createDevToolsFrame(doc, className) {
   const frame = doc.createXULElement("iframe");
   frame.flex = 1; // Required to be able to shrink when the window shrinks
   frame.className = className;
-  if (Services.prefs.getBoolPref("devtools.toolbox.content-frame", false)) {
-    frame.setAttribute("type", "content");
-  }
+  frame.setAttribute("type", "content");
   frame.tooltip = "aHTMLTooltip";
   return frame;
 }
 
 exports.Hosts = {
   bottom: BottomHost,
   left: LeftHost,
   right: RightHost,