Bug 1440383 - Remove XBL accessibility role="xul:pane" and role="none" r=surkov
authorTimothy Guan-tin Chien <timdream@gmail.com>
Wed, 28 Feb 2018 13:09:29 -0800
changeset 406070 95d6f33e9bc34bc71f10aed154af8d9be11cbff3
parent 406069 aacc7cd0f266ac061ef38f6baa9cb9f479d3749c
child 406071 520a7d1de634c866b74e3bc4271677a52a3e9d18
child 406164 36806a2e73253732351b9d6079de744c484a64a5
push id60445
push usertimdream@gmail.com
push dateThu, 01 Mar 2018 19:30:47 +0000
treeherderautoland@95d6f33e9bc3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssurkov
bugs1440383
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1440383 - Remove XBL accessibility role="xul:pane" and role="none" r=surkov MozReview-Commit-ID: GJ0aouAzS77
accessible/base/nsAccessibilityService.cpp
--- a/accessible/base/nsAccessibilityService.cpp
+++ b/accessible/base/nsAccessibilityService.cpp
@@ -1467,34 +1467,31 @@ nsAccessibilityService::Shutdown()
 }
 
 already_AddRefed<Accessible>
 nsAccessibilityService::CreateAccessibleByType(nsIContent* aContent,
                                                DocAccessible* aDoc)
 {
   nsAutoString role;
   nsCoreUtils::XBLBindingRole(aContent, role);
-  if (role.IsEmpty() || role.EqualsLiteral("none"))
+  if (role.IsEmpty())
     return nullptr;
 
   RefPtr<Accessible> accessible;
 #ifdef MOZ_XUL
   // XUL controls
   if (role.EqualsLiteral("xul:colorpicker")) {
     accessible = new XULColorPickerAccessible(aContent, aDoc);
 
   } else if (role.EqualsLiteral("xul:colorpickertile")) {
     accessible = new XULColorPickerTileAccessible(aContent, aDoc);
 
   } else if (role.EqualsLiteral("xul:link")) {
     accessible = new XULLinkAccessible(aContent, aDoc);
 
-  } else if(role.EqualsLiteral("xul:pane")) {
-    accessible = new EnumRoleAccessible<roles::PANE>(aContent, aDoc);
-
   } else if (role.EqualsLiteral("xul:panel")) {
     if (aContent->IsElement() &&
         aContent->AsElement()->AttrValueIs(kNameSpaceID_None,
                                            nsGkAtoms::noautofocus,
                                            nsGkAtoms::_true, eCaseMatters))
       accessible = new XULAlertAccessible(aContent, aDoc);
     else
       accessible = new EnumRoleAccessible<roles::PANE>(aContent, aDoc);