author | Khyati Agarwal <f20160385@hyderabad.bits-pilani.ac.in> |
Wed, 03 Apr 2019 12:08:35 +0000 | |
changeset 467765 | 9102e660cb6fad57ec10c657b7a7c4c85a66c19d |
parent 467764 | 4c124c1db332a83c49893d8a0994d47012eb268d |
child 467766 | 92e46765bf56c06040ce01d0bb007272f3a0c6e6 |
push id | 82185 |
push user | dluca@mozilla.com |
push date | Wed, 03 Apr 2019 13:16:15 +0000 |
treeherder | autoland@9102e660cb6f [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | sfink |
bugs | 1529981 |
milestone | 68.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
js/src/gc/GC.cpp | file | annotate | diff | comparison | revisions |
--- a/js/src/gc/GC.cpp +++ b/js/src/gc/GC.cpp @@ -2610,31 +2610,30 @@ struct ArenasToUpdate { private: AllocKinds kinds; // Selects which thing kinds to update Zone* zone; // Zone to process AllocKind kind; // Current alloc kind to process Arena* arena; // Next arena to process AllocKind nextAllocKind(AllocKind i) { return AllocKind(uint8_t(i) + 1); } - bool shouldProcessKind(AllocKind kind); Arena* next(AutoLockHelperThreadState& lock); }; ArenasToUpdate::ArenasToUpdate(Zone* zone, AllocKinds kinds) : kinds(kinds), zone(zone), kind(AllocKind::FIRST), arena(nullptr) { MOZ_ASSERT(zone->isGCCompacting()); } Arena* ArenasToUpdate::next(AutoLockHelperThreadState& lock) { // Find the next arena to update. // - // This iterates through the GC thing kinds filtered by shouldProcessKind(), - // and then through thea arenas of that kind. All state is held in the - // object and we just return when we find an arena. + // This iterates through the GC thing kinds and then through the arenas of + // that kind. All state is held in the object and we just return when we find + // an arena. for (; kind < AllocKind::LIMIT; kind = nextAllocKind(kind)) { if (kinds.contains(kind)) { if (!arena) { arena = zone->arenas.getFirstArena(kind); } else { arena = arena->next; }