Bug 1121623 part 3. Switch WebrtcGlobalInformation to being a namespace. r=peterv
authorBoris Zbarsky <bzbarsky@mit.edu>
Fri, 24 May 2019 07:22:22 +0000
changeset 475398 8e672b4e0a3e3ed151a91abbca41cebf2692dd4f
parent 475397 5d10803def3ee7f35ee69f4a67870e7f9885e79a
child 475399 4d9f7977a103255ef5d9e9424b6233482b25c304
push id86310
push userbzbarsky@mozilla.com
push dateFri, 24 May 2019 15:01:13 +0000
treeherderautoland@1bec5b571ed1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspeterv
bugs1121623
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1121623 part 3. Switch WebrtcGlobalInformation to being a namespace. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D32201
dom/bindings/Bindings.conf
dom/webidl/WebrtcGlobalInformation.webidl
--- a/dom/bindings/Bindings.conf
+++ b/dom/bindings/Bindings.conf
@@ -1514,18 +1514,16 @@ DOMInterfaces = {
     'concrete': False,
 },
 
 # WebRTC
 
 'WebrtcGlobalInformation': {
     'nativeType': 'mozilla::dom::WebrtcGlobalInformation',
     'headerFile': 'WebrtcGlobalInformation.h',
-    'wrapperCache': False,
-    'concrete': False,
 },
 
 'Window': {
     'nativeType': 'nsGlobalWindowInner',
     'headerFile': 'nsGlobalWindow.h',
     'binaryNames': {
         'postMessage': 'postMessageMoz',
     },
--- a/dom/webidl/WebrtcGlobalInformation.webidl
+++ b/dom/webidl/WebrtcGlobalInformation.webidl
@@ -7,35 +7,34 @@
 dictionary WebrtcGlobalStatisticsReport {
   sequence<RTCStatsReportInternal> reports;
 };
 
 callback WebrtcGlobalStatisticsCallback = void (WebrtcGlobalStatisticsReport reports);
 callback WebrtcGlobalLoggingCallback = void (sequence<DOMString> logMessages);
 
 [ChromeOnly]
-interface WebrtcGlobalInformation {
+namespace WebrtcGlobalInformation {
 
   [Throws]
-  static void getAllStats(WebrtcGlobalStatisticsCallback callback,
-                          optional DOMString pcIdFilter);
+  void getAllStats(WebrtcGlobalStatisticsCallback callback,
+                   optional DOMString pcIdFilter);
 
-  static void clearAllStats();
+  void clearAllStats();
 
   [Throws]
-  static void getLogging(DOMString pattern,
-                         WebrtcGlobalLoggingCallback callback);
+  void getLogging(DOMString pattern, WebrtcGlobalLoggingCallback callback);
 
-  static void clearLogging();
+  void clearLogging();
 
   // NSPR WebRTC Trace debug level (0 - 65535)
   //
   // Notes:
   // - Setting a non-zero debug level turns on gathering of log for file output.
   // - Subsequently setting a zero debug level writes that log to disk.
 
-  static attribute long debugLevel;
+  attribute long debugLevel;
 
   // WebRTC AEC debugging enable
-  static attribute boolean aecDebug;
+  attribute boolean aecDebug;
 
-  static readonly attribute DOMString aecDebugLogDir;
+  readonly attribute DOMString aecDebugLogDir;
 };