Bug 1657312 - Don't round clip rect. r=mstange
authorMatt Woodrow <mwoodrow@mozilla.com>
Fri, 14 Aug 2020 06:16:52 +0000
changeset 545918 8e06ab2926d5e20123c73f1d67c3187f7b353882
parent 545917 3a848c81a60655c298e6f2060abaef43f0e99652
child 545919 d6a45cf0fcc64966c481f898b453cb6d38cac7ae
push id124894
push usermwoodrow@mozilla.com
push dateTue, 25 Aug 2020 04:23:35 +0000
treeherderautoland@8e06ab2926d5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1657312
milestone82.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1657312 - Don't round clip rect. r=mstange Depends on D86088 Differential Revision: https://phabricator.services.mozilla.com/D87023
gfx/webrender_bindings/DCLayerTree.cpp
--- a/gfx/webrender_bindings/DCLayerTree.cpp
+++ b/gfx/webrender_bindings/DCLayerTree.cpp
@@ -367,17 +367,16 @@ void DCLayerTree::AddSurface(wr::NativeS
   // DirectComposition does have an option for pre-transform clipping, if you
   // create an explicit IDCompositionEffectGroup object and set a 3D transform
   // on that. I suspect that will perform worse though, so we should only do
   // that for complex transforms (which are never provided right now).
   MOZ_ASSERT(transform.IsRectilinear());
   gfx::Rect clip = transform.Inverse().TransformBounds(
       gfx::Rect(aClipRect.origin.x, aClipRect.origin.y, aClipRect.size.width,
                 aClipRect.size.height));
-  clip.Round();
   // Set the clip rect - converting from world space to the pre-offset space
   // that DC requires for rectangle clips.
   visual->SetClip(D2DRect(clip));
 
   // TODO: The input matrix is a 4x4, but we only support a 3x2 at
   // the D3D API level (unless we QI to IDCompositionVisual3, which might
   // not be available?).
   // Should we assert here, or restrict at the WR API level.