Bug 1311277 Part 1 - Convert |other| argument to Mozilla coding style. r=froydnj
authorTing-Yu Lin <tlin@mozilla.com>
Wed, 19 Oct 2016 13:24:23 +0800
changeset 318818 8cf3c1b52fac16bb337dd2d0f99bf0d862d2b14b
parent 318817 fcadf6ec5ccf67c480047de89b5d063116938fea
child 318819 ba5d30bdad0d84ae6e1809a5946ea136a92dad44
push id33394
push usertlin@mozilla.com
push dateFri, 21 Oct 2016 04:34:16 +0000
treeherderautoland@2626096d6704 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1311277
milestone52.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1311277 Part 1 - Convert |other| argument to Mozilla coding style. r=froydnj MozReview-Commit-ID: JcEloAe5dlA
mfbt/LinkedList.h
--- a/mfbt/LinkedList.h
+++ b/mfbt/LinkedList.h
@@ -120,44 +120,44 @@ private:
 
 public:
   LinkedListElement()
     : mNext(this),
       mPrev(this),
       mIsSentinel(false)
   { }
 
-  LinkedListElement(LinkedListElement<T>&& other)
-    : mIsSentinel(other.mIsSentinel)
+  LinkedListElement(LinkedListElement<T>&& aOther)
+    : mIsSentinel(aOther.mIsSentinel)
   {
-    if (!other.isInList()) {
+    if (!aOther.isInList()) {
       mNext = this;
       mPrev = this;
       return;
     }
 
-    MOZ_ASSERT(other.mNext->mPrev == &other);
-    MOZ_ASSERT(other.mPrev->mNext == &other);
+    MOZ_ASSERT(aOther.mNext->mPrev == &aOther);
+    MOZ_ASSERT(aOther.mPrev->mNext == &aOther);
 
     /*
-     * Initialize |this| with |other|'s mPrev/mNext pointers, and adjust those
+     * Initialize |this| with |aOther|'s mPrev/mNext pointers, and adjust those
      * element to point to this one.
      */
-    mNext = other.mNext;
-    mPrev = other.mPrev;
+    mNext = aOther.mNext;
+    mPrev = aOther.mPrev;
 
     mNext->mPrev = this;
     mPrev->mNext = this;
 
     /*
-     * Adjust |other| so it doesn't think it's in a list.  This makes it
+     * Adjust |aOther| so it doesn't think it's in a list.  This makes it
      * safely destructable.
      */
-    other.mNext = &other;
-    other.mPrev = &other;
+    aOther.mNext = &aOther;
+    aOther.mPrev = &aOther;
   }
 
   ~LinkedListElement()
   {
     if (!mIsSentinel && isInList()) {
       remove();
     }
   }