Bug 1420934 - Ensure `npm install` on netmonitor before installing in webconsole;r=Honza
authorBrian Grinstead <bgrinstead@mozilla.com>
Thu, 11 Jan 2018 09:28:52 -0800
changeset 398802 8c3494442dc435a481052dfe1d38101145fe2bf1
parent 398801 8dc35c7698538e45978406ce56466875b6df77fd
child 398803 adb5fab118c560f437c9891c98a4c335b635800a
push id57904
push userbgrinstead@mozilla.com
push dateThu, 11 Jan 2018 18:16:58 +0000
treeherderautoland@8c3494442dc4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1420934
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1420934 - Ensure `npm install` on netmonitor before installing in webconsole;r=Honza If the netmonitor hasn't had `npm install` ran, then running the webconsole tests fail, because the webconsole depends on netmonitor, and the babel plugin "transform-object-rest-spread" defined in netmonitor/.babelrc cannot be resolved unless if it's been installed. MozReview-Commit-ID: KyQgja5rRpg
devtools/client/webconsole/package.json
--- a/devtools/client/webconsole/package.json
+++ b/devtools/client/webconsole/package.json
@@ -1,15 +1,16 @@
 {
   "name": "webconsole",
   "version": "0.0.1",
   "engines": {
     "node": ">=6.9.0"
   },
   "scripts": {
+    "preinstall": "cd ../netmonitor && npm install && cd ../webconsole",
     "start": "cross-env NODE_ENV=production node bin/dev-server",
     "dev": "node bin/dev-server",
     "test": "cross-env NODE_ENV=test NODE_PATH=../../../ mocha new-console-output/test/**/*.test.js --compilers js:babel-register -r jsdom-global/register -r ./new-console-output/test/require-helper.js"
   },
   "dependencies": {
     "amd-loader": "0.0.5",
     "babel-preset-es2015": "^6.6.0",
     "babel-preset-es2017": "^6.24.1",