Bug 1346725 - removed useless null check in DoSampleStackTrace. r=mstange
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Mon, 13 Mar 2017 12:50:22 +0200
changeset 347753 8a30570bc7387074aa6078597c3549dd02ba69f3
parent 347752 e0a87984f6139addfde9dbea86b89ca9b2cb15b6
child 347754 a654b91969e4309c26488f423bb8acc02d8dfb73
push id38912
push userbpostelnicu@mozilla.com
push dateWed, 15 Mar 2017 14:26:39 +0000
treeherderautoland@8a30570bc738 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1346725
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1346725 - removed useless null check in DoSampleStackTrace. r=mstange MozReview-Commit-ID: 374xPqkTMxJ
tools/profiler/core/platform.cpp
--- a/tools/profiler/core/platform.cpp
+++ b/tools/profiler/core/platform.cpp
@@ -931,17 +931,17 @@ DoNativeBacktrace(PS::LockRef aLock, Pro
 
 static void
 DoSampleStackTrace(PS::LockRef aLock, ProfileBuffer* aBuffer,
                    TickSample* aSample)
 {
   NativeStack nativeStack = { nullptr, nullptr, 0, 0 };
   MergeStacksIntoProfile(aBuffer, aSample, nativeStack);
 
-  if (aSample && gPS->FeatureLeaf(aLock)) {
+  if (gPS->FeatureLeaf(aLock)) {
     aBuffer->addTag(ProfileBufferEntry::NativeLeafAddr((void*)aSample->pc));
   }
 }
 
 // This function is called for each sampling period with the current program
 // counter. It is called within a signal and so must be re-entrant.
 static void
 Tick(PS::LockRef aLock, ProfileBuffer* aBuffer, TickSample* aSample)