Bug 1398983 - Remove warning about assuming gecko style system. r=me
authorBobby Holley <bobbyholley@gmail.com>
Fri, 15 Sep 2017 12:25:46 -0700
changeset 381200 89ee33156cdec7c01c9c4c124dc20f4704c113d4
parent 381199 1dc22f1138e63343e361c2d52b2c46c4843be750
child 381224 437eae179c71eb3fcb1af49a48b4e315d6a47ab5
push id51346
push userbholley@mozilla.com
push dateFri, 15 Sep 2017 19:33:25 +0000
treeherderautoland@89ee33156cde [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1398983
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1398983 - Remove warning about assuming gecko style system. r=me MozReview-Commit-ID: BCeG81uxLvS
dom/base/nsDocument.cpp
--- a/dom/base/nsDocument.cpp
+++ b/dom/base/nsDocument.cpp
@@ -13485,17 +13485,18 @@ nsIDocument::UpdateStyleBackendType()
   mStyleBackendType = StyleBackendType::Gecko;
 
 #ifdef MOZ_STYLO
   if (nsLayoutUtils::StyloEnabled()) {
     if (IsBeingUsedAsImage()) {
       // Enable stylo for SVG-as-image.
       mStyleBackendType = StyleBackendType::Servo;
     } else if (!mDocumentContainer) {
-      NS_WARNING("stylo: No docshell yet, assuming Gecko style system");
+      // Not docshell, assume Gecko. Various callers can end up setting this
+      // explicitly afterwards to inherit it in various situations.
     } else if (!IsXULDocument() && IsContentDocument()) {
       // Disable stylo for about: pages other than about:blank, since
       // they tend to use unsupported selectors like XUL tree pseudos.
       bool isAbout = false;
       mDocumentURI->SchemeIs("about", &isAbout);
       if (!isAbout || NS_IsAboutBlank(mDocumentURI)) {
         mStyleBackendType = StyleBackendType::Servo;
       }