Bug 1493272 - Run a top level build in the tup backend when "faster" or "binaries" is passed to |./mach build| r=ted,firefox-build-system-reviewers
authorChris Manchester <cmanchester@mozilla.com>
Mon, 01 Oct 2018 19:11:59 +0000
changeset 439017 88273f13d441593babcfd658dd9b9c9c69da40ff
parent 439016 7783682f8ba7753ad6bdccd716edf37cb53ebc22
child 439018 9d5e7b73af8f2576a76a1014b392fc4258c2683e
push id70192
push usercmanchester@mozilla.com
push dateMon, 01 Oct 2018 19:22:24 +0000
treeherderautoland@88273f13d441 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted, firefox-build-system-reviewers
bugs1493272
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1493272 - Run a top level build in the tup backend when "faster" or "binaries" is passed to |./mach build| r=ted,firefox-build-system-reviewers Differential Revision: https://phabricator.services.mozilla.com/D7319
python/mozbuild/mozbuild/backend/tup.py
--- a/python/mozbuild/mozbuild/backend/tup.py
+++ b/python/mozbuild/mozbuild/backend/tup.py
@@ -294,16 +294,21 @@ class TupBackend(CommonBackend):
         for line in make_extra:
             if line.startswith('export '):
                 line = line[len('export '):]
             key, value = line.split('=')
             env[key] = value
         return env
 
     def build(self, config, output, jobs, verbose, what=None):
+        if len(what) == 1 and what[0] in ('binaries', 'faster'):
+            print("\nNOTE: `binaries` and `faster` targets are subsumed by the "
+                  "top-level build command in the Tup backend. Running `build` "
+                  "with no parameters instead.\n")
+            what = None
         if not what:
             what = ['%s/<default>' % config.topobjdir]
         else:
             # Translate relsrcdir paths to the objdir when possible.
             translated = []
             topsrcdir = mozpath.normpath(config.topsrcdir)
             for path in what:
                 path = mozpath.abspath(path)