Bug 1565311 - Add --no-install to |mach geckoview-junit|. r=nalexander
authorAgi Sferro <agi@sferro.dev>
Thu, 11 Jul 2019 20:41:56 +0000
changeset 482456 87ed0e92e9e1582d8b0b141cc0c1eceb1a625a32
parent 482455 8c13a10992ccaa7fe766ead75a01f290bfcc858e
child 482457 13b62d64e105c6bba7ebd89c10068c323d7e81bd
push id89785
push userasferro@mozilla.com
push dateThu, 11 Jul 2019 20:56:38 +0000
treeherderautoland@87ed0e92e9e1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1565311
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1565311 - Add --no-install to |mach geckoview-junit|. r=nalexander Differential Revision: https://phabricator.services.mozilla.com/D37754
testing/mochitest/mach_commands.py
--- a/testing/mochitest/mach_commands.py
+++ b/testing/mochitest/mach_commands.py
@@ -493,26 +493,30 @@ class MachCommands(MachCommandBase):
 
 @CommandProvider
 class GeckoviewJunitCommands(MachCommandBase):
 
     @Command('geckoview-junit', category='testing',
              conditions=[conditions.is_android],
              description='Run remote geckoview junit tests.',
              parser=setup_junit_argument_parser)
-    def run_junit(self, **kwargs):
+    @CommandArgument('--no-install', help='Do not try to install application on device before ' +
+                     'running (default: False)',
+                     action='store_true',
+                     default=False)
+    def run_junit(self, no_install, **kwargs):
         self._ensure_state_subdir_exists('.')
 
         from mozrunner.devices.android_device import (grant_runtime_permissions,
                                                       get_adb_path,
                                                       verify_android_device)
         # verify installation
         app = kwargs.get('app')
         device_serial = kwargs.get('deviceSerial')
-        verify_android_device(self, install=True, xre=False, app=app,
+        verify_android_device(self, install=not no_install, xre=False, app=app,
                               device_serial=device_serial)
         grant_runtime_permissions(self, app, device_serial=device_serial)
 
         if not kwargs.get('adbPath'):
             kwargs['adbPath'] = get_adb_path(self)
 
         if not kwargs.get('log'):
             from mozlog.commandline import setup_logging