Backed out changeset a9afb304dbb6 (bug 1333736) for failing TestNavigate.test_about_blank_for_new_docshell and TestNavigate.test_focus_after_navigation. r=backout on a CLOSED TREE
authorSebastian Hengst <archaeopteryx@coole-files.de>
Fri, 27 Jan 2017 19:13:02 +0100
changeset 331389 831c20c3086bf27da1ea8170090df58746caa152
parent 331388 8b0fc745a65e390d8ad2989a1abd747c43f232af
child 331390 222e3a9abd94b70a9eec9cc43621ab4843aa8afa
push id36582
push userarchaeopteryx@coole-files.de
push dateFri, 27 Jan 2017 18:13:18 +0000
treeherderautoland@831c20c3086b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1333736
milestone54.0a1
backs outa9afb304dbb69dfab72128cf355f627f9af25828
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset a9afb304dbb6 (bug 1333736) for failing TestNavigate.test_about_blank_for_new_docshell and TestNavigate.test_focus_after_navigation. r=backout on a CLOSED TREE
testing/marionette/client/marionette_driver/geckoinstance.py
testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py
--- a/testing/marionette/client/marionette_driver/geckoinstance.py
+++ b/testing/marionette/client/marionette_driver/geckoinstance.py
@@ -381,18 +381,20 @@ class DesktopInstance(GeckoInstance):
 
         # Indicate that the download panel has been shown once so that whichever
         # download test runs first doesn"t show the popup inconsistently
         "browser.download.panel.shown": True,
 
         # Do not show the EULA notification which can interfer with tests
         "browser.EULA.override": True,
 
-        # Turn off about:newtab and make use of about:blank instead for new opened tabs
-        "browser.newtabpage.enabled": False,
+        # Bug 1145668, 1312674
+        # Turn off once Marionette can correctly handle error pages, and doesn't
+        # hang when about:blank gets loaded twice
+        "browser.newtabpage.enabled": True,
         # Assume the about:newtab page"s intro panels have been shown to not depend on
         # which test runs first and happens to open about:newtab
         "browser.newtabpage.introShown": True,
 
         # Background thumbnails in particular cause grief, and disabling thumbnails
         # in general can"t hurt - we re-enable them when tests need them
         "browser.pagethumbnails.capturing_disabled": True,
 
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py
@@ -153,29 +153,23 @@ class TestNavigate(WindowManagerMixin, M
     def test_fragment(self):
         doc = inline("<p id=foo>")
         self.marionette.navigate(doc)
         self.marionette.execute_script("window.visited = true", sandbox=None)
         self.marionette.navigate("%s#foo" % doc)
         self.assertTrue(self.marionette.execute_script(
             "return window.visited", sandbox=None))
 
-    @skip_if_mobile("Bug 1334095 - Timeout: No new tab has been opened")
+    @skip_if_mobile("Fennec doesn't support other chrome windows")
     def test_about_blank_for_new_docshell(self):
         """ Bug 1312674 - Hang when loading about:blank for a new docshell."""
-        def open_with_link():
-            self.marionette.navigate(self.marionette.absolute_url("windowHandles.html"))
-
-            link = self.marionette.find_element(By.ID, "new-tab")
-            link.click()
-
-        # Open a new tab to get a new docshell created
-        new_tab = self.open_tab(trigger=open_with_link)
-        self.marionette.switch_to_window(new_tab)
-        self.assertEqual(self.marionette.get_url(), "about:blank")
+        # Open a window to get a new docshell created for the first tab
+        with self.marionette.using_context("chrome"):
+            tab = self.open_tab(lambda: self.marionette.execute_script(" window.open() "))
+            self.marionette.switch_to_window(tab)
 
         self.marionette.navigate('about:blank')
         self.marionette.close()
         self.marionette.switch_to_window(self.start_window)
 
     def test_error_on_tls_navigation(self):
         self.assertRaises(errors.InsecureCertificateException,
                           self.marionette.navigate, self.fixtures.where_is("/test.html", on="https"))