Bug 1729628 [wpt PR 30392] - Apply list item quirks only when the nested list is block-level, a=testonly
authorKoji Ishii <kojii@chromium.org>
Tue, 14 Sep 2021 09:57:18 +0000
changeset 592768 82a81e9eacc12618394b49196d16ea4680046da1
parent 592767 34826a21941a4753fa6d611b5f8c395e6fb5278e
child 592769 e4f14316e212bc238fa058d5b3053fc1f51af639
push id150123
push userwptsync@mozilla.com
push dateTue, 21 Sep 2021 14:30:52 +0000
treeherderautoland@14de788574ae [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1729628, 30392, 2885398, 1246932, 1206409, 3145018, 919158
milestone94.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1729628 [wpt PR 30392] - Apply list item quirks only when the nested list is block-level, a=testonly Automatic update from web-platform-tests Apply list item quirks only when the nested list is block-level This patch chagnes to apply quirks for a list-item occupying the whole line only if the nested list is block-level. When applying this quirks, list markers are handled like a regular child. r883403 crrev.com/c/2885398 changed to handle list markers at |NGBlockLayoutAlgorithm| to support NG block fragmentation. These two when combined causes the list marker not laid out if the nested list is not block-level. This may change some visual behaviors, but I think this is ok: a) This quirks is not in the quirks spec[1] and not implemented in Gecko. b) The previous CL had a visual difference in this case in M92 but no reports so far. [1]: https://quirks.spec.whatwg.org/ Bug: 1246932, 1206409 Change-Id: Ia58a1b788313d3d9f221fd010cdd1a906551ab8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3145018 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#919158} -- wpt-commits: 5d2020c4030c4ae47850b9a24ca600788f45d21e wpt-pr: 30392
testing/web-platform/tests/quirks/crashtests/list-item-whole-line-quirks-crash.html
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/quirks/crashtests/list-item-whole-line-quirks-crash.html
@@ -0,0 +1,5 @@
+<!-- quirks -->
+<div>a<ul><li><ul style='float: left'></ul></li></ul></div>
+<div>a<ul><li><ul style='position: absolute'></ul></li></ul></div>
+<div>a<ul><li><ul style='display: inline'></ul></li></ul></div>
+<div>a<ul><li><ul style='display: inline-block'></ul></li></ul></div>