Bug 1627618 - Part 19: Don't call the always-inline UrshOperation in some places. r=jandem
authorAndré Bargull <andre.bargull@gmail.com>
Tue, 07 Apr 2020 08:43:18 +0000
changeset 522664 80d90187293bc279bd978d307fee5006170a3d14
parent 522663 7a74700f4e86e4d61f2d2045f968002afacb62d4
child 522665 5b653e25e757fb28b304ca59e5bf653bba8e93fb
push id112239
push userccoroiu@mozilla.com
push dateTue, 07 Apr 2020 15:04:11 +0000
treeherderautoland@5b653e25e757 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1627618
milestone77.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1627618 - Part 19: Don't call the always-inline UrshOperation in some places. r=jandem Noticed while working on the previous part: `js::UrshOperation()` is marked as `MOZ_ALWAYS_INLINE`, but these callers don't need to use the inlined version and instead should use `js::UrshValues()`. Differential Revision: https://phabricator.services.mozilla.com/D69799
js/src/jit/BaselineIC.cpp
js/src/jit/IonIC.cpp
js/src/jit/Recover.cpp
--- a/js/src/jit/BaselineIC.cpp
+++ b/js/src/jit/BaselineIC.cpp
@@ -3573,17 +3573,17 @@ bool DoBinaryArithFallback(JSContext* cx
     }
     case JSOp::Rsh: {
       if (!BitRsh(cx, &lhsCopy, &rhsCopy, ret)) {
         return false;
       }
       break;
     }
     case JSOp::Ursh: {
-      if (!UrshOperation(cx, &lhsCopy, &rhsCopy, ret)) {
+      if (!UrshValues(cx, &lhsCopy, &rhsCopy, ret)) {
         return false;
       }
       break;
     }
     default:
       MOZ_CRASH("Unhandled baseline arith op");
   }
 
--- a/js/src/jit/IonIC.cpp
+++ b/js/src/jit/IonIC.cpp
@@ -634,17 +634,17 @@ bool IonBinaryArithIC::update(JSContext*
     }
     case JSOp::Rsh: {
       if (!BitRsh(cx, &lhsCopy, &rhsCopy, ret)) {
         return false;
       }
       break;
     }
     case JSOp::Ursh: {
-      if (!UrshOperation(cx, &lhsCopy, &rhsCopy, ret)) {
+      if (!UrshValues(cx, &lhsCopy, &rhsCopy, ret)) {
         return false;
       }
       break;
     }
     default:
       MOZ_CRASH("Unhandled binary arith op");
   }
 
--- a/js/src/jit/Recover.cpp
+++ b/js/src/jit/Recover.cpp
@@ -279,17 +279,17 @@ bool MUrsh::writeRecoverData(CompactBuff
 RUrsh::RUrsh(CompactBufferReader& reader) {}
 
 bool RUrsh::recover(JSContext* cx, SnapshotIterator& iter) const {
   RootedValue lhs(cx, iter.read());
   RootedValue rhs(cx, iter.read());
   MOZ_ASSERT(!lhs.isObject() && !rhs.isObject());
 
   RootedValue result(cx);
-  if (!js::UrshOperation(cx, &lhs, &rhs, &result)) {
+  if (!js::UrshValues(cx, &lhs, &rhs, &result)) {
     return false;
   }
 
   iter.storeInstructionResult(result);
   return true;
 }
 
 bool MSignExtendInt32::writeRecoverData(CompactBufferWriter& writer) const {