Bug 1705229 [wpt PR 28488] - Consider HasOverflow true as valid scenario for HandleAtomicInline, a=testonly
authorJavier Fernández García-Boente <jfernandez@igalia.com>
Fri, 23 Apr 2021 10:20:56 +0000
changeset 577276 8071e722c44268961562d91703e9eb81ad2d3570
parent 577275 1a04a2adcf61042e61459f6884c32f923e355a2c
child 577277 e645b452feaebc78c6cfaa596ef6ea2443bcc62e
push id141827
push userwptsync@mozilla.com
push dateSat, 24 Apr 2021 02:11:12 +0000
treeherderautoland@3a7d9d49c316 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1705229, 28488, 1197974, 2821314, 873246
milestone90.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1705229 [wpt PR 28488] - Consider HasOverflow true as valid scenario for HandleAtomicInline, a=testonly Automatic update from web-platform-tests Consider HasOverflow true as valid scenario for HandleAtomicInline The table caption element always have 0 available space, since its text consumes all of it. Hence, adding an empty span with negative margins may imply the line to overflow. If we add some atomic-inline elements in such caption, we might need to process them under the scenario of a NGInlineInfo which has true sa HasOverflow flag. In the current code, there is an assertion that under kContinue state and negative remaining_width (implying overflow) it's not valid to have the line-info's HasOverflow flag to true. I believe this assertion is contradictory and that this is indeed a valid scenario, hence, this CL removes such assertion. Bug: 1197974 Change-Id: I80c48e5dffe5e5ee25fcb4cc15db02d584adc4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2821314 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#873246} -- wpt-commits: f55b3e4b7eae784bcf6369ce5b85ae7ceebae843 wpt-pr: 28488
testing/web-platform/tests/css/css-text/crashtests/rendering-table-caption-with-negative-margins-crash.html
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-text/crashtests/rendering-table-caption-with-negative-margins-crash.html
@@ -0,0 +1,11 @@
+<!doctype html>
+<title>CSS Text Test: Crash rendering a table caption with empty span and negative margins</title>
+<link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com" />
+<link rel="help" href="https://crbug.com/1197974">
+<meta name="assert" content="The test doesn't crash in debug"/>
+<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
+<style>
+    table { font: 20px/1 Ahem; }
+    span { margin: -40px; }
+</style>
+<table><caption>X<span></span><input></input><textarea></textarea></caption></table>