Bug 632954 - Explicitly set NEED_XVFB to false if need-xvfb isn't set; r=tomprince
authorMike Shal <mshal@mozilla.com>
Mon, 18 Mar 2019 23:52:52 +0000
changeset 465195 7df96a607be86a4230286e1aaee79d1315d73110
parent 465194 8acddb36a3166a7863a00e133920fd14f20f7502
child 465196 a257e15d267f4589ff7d55273643bc8c19bfec8c
push id80949
push usernerli@mozilla.com
push dateWed, 20 Mar 2019 10:36:39 +0000
treeherderautoland@d8203a0665d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstomprince
bugs632954
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 632954 - Explicitly set NEED_XVFB to false if need-xvfb isn't set; r=tomprince test-linux.sh defaults to true for NEED_XVFB, while build-linux.sh defaults to false. If we are using test-linux.sh from mozharness (rather than mozharness-test), we need to explicitly set NEED_XVFB to false in order to not use xvfb. Differential Revision: https://phabricator.services.mozilla.com/D22820
taskcluster/taskgraph/transforms/job/mozharness.py
--- a/taskcluster/taskgraph/transforms/job/mozharness.py
+++ b/taskcluster/taskgraph/transforms/job/mozharness.py
@@ -205,16 +205,18 @@ def mozharness_on_docker_worker_setup(co
     # not builds.
     if not run['keep-artifacts']:
         env['DIST_TARGET_UPLOADS'] = ''
         env['DIST_UPLOADS'] = ''
 
     # Xvfb
     if run['need-xvfb']:
         env['NEED_XVFB'] = 'true'
+    else:
+        env['NEED_XVFB'] = 'false'
 
     if run['tooltool-downloads']:
         internal = run['tooltool-downloads'] == 'internal'
         docker_worker_add_tooltool(config, job, taskdesc, internal=internal)
 
     # Retry if mozharness returns TBPL_RETRY
     worker['retry-exit-status'] = [4]