Backed out changeset 7f0e02401370 (bug 1543696) for browser-chrome failures at toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
authorCoroiu Cristina <ccoroiu@mozilla.com>
Sat, 13 Apr 2019 12:59:58 +0300
changeset 469397 7dad55e9bd2bd60ea5462c2cfa1281a82aa0a4b6
parent 469396 7f0e024013704d89e01b6f8103fbfd6ef5f0107b
child 469398 1ee98a3cd8fb212340a25bdc3f0764dfca08daa0
push id83125
push userccoroiu@mozilla.com
push dateSat, 13 Apr 2019 10:00:52 +0000
treeherderautoland@7dad55e9bd2b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1543696
milestone68.0a1
backs out7f0e024013704d89e01b6f8103fbfd6ef5f0107b
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 7f0e02401370 (bug 1543696) for browser-chrome failures at toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
toolkit/components/extensions/test/browser/browser_ext_themes_experiment.js
toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
--- a/toolkit/components/extensions/test/browser/browser_ext_themes_experiment.js
+++ b/toolkit/components/extensions/test/browser/browser_ext_themes_experiment.js
@@ -1,18 +1,16 @@
 "use strict";
 
 // This test checks whether the theme experiments work
 
 add_task(async function setup() {
-  if (AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS) {
-    await SpecialPowers.pushPrefEnv({
-      set: [["extensions.legacy.enabled", true]],
-    });
-  }
+  await SpecialPowers.pushPrefEnv({
+    set: [["extensions.legacy.enabled", true]],
+  });
 });
 
 add_task(async function test_experiment_static_theme() {
   let extension = ExtensionTestUtils.loadExtension({
     manifest: {
       theme: {
         colors: {
           some_color_property: "#ff00ff",
--- a/toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
+++ b/toolkit/components/extensions/test/browser/browser_ext_themes_warnings.js
@@ -68,21 +68,17 @@ add_task(async function test_dynamic_the
       `Unrecognized theme property found: ${property}.such_property`
     );
   }
 
   await extension.unload();
 });
 
 add_task(async function test_experiment() {
-  if (AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS) {
-    await SpecialPowers.pushPrefEnv({
-      set: [["extensions.legacy.enabled", true]],
-    });
-  }
+  Services.prefs.setBoolPref("extensions.legacy.enabled", true);
 
   info("Testing that experiments are handled correctly when legacy pref is enabled");
 
   let extension = ExtensionTestUtils.loadExtension({
     manifest: {
       theme: {
         properties: {
           such_property: "much_wow",
@@ -106,19 +102,17 @@ add_task(async function test_experiment(
       extension.startup,
       "Unrecognized theme property found: properties.unknown_property"
     );
   }
   await extension.unload();
 
   info("Testing that experiments are handled correctly when legacy pref is disabled");
 
-  if (AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS) {
-    await SpecialPowers.popPrefEnv();
-  }
+  Services.prefs.setBoolPref("extensions.legacy.enabled", false);
 
   extension = ExtensionTestUtils.loadExtension({
     manifest: {
       theme: {
         properties: {
           such_property: "much_wow",
         },
       },