Bug 1724212 - add a tooltip and show more of the 'not secure' item so languages other than English fit, r=pbz
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Tue, 17 Aug 2021 14:15:09 +0000
changeset 589111 7d8ffaf9addd6ffb466a4eb50343d5c8c35d62c0
parent 589110 61127b8f451c707a3522fc5eb4dca266eb5343d7
child 589112 6e0107face9ee79785e8e0ce5a61e52f5293ff2b
push id148154
push usergijskruitbosch@gmail.com
push dateTue, 17 Aug 2021 14:17:33 +0000
treeherderautoland@7d8ffaf9addd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspbz
bugs1724212
milestone93.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1724212 - add a tooltip and show more of the 'not secure' item so languages other than English fit, r=pbz Differential Revision: https://phabricator.services.mozilla.com/D122851
browser/base/content/browser-siteIdentity.js
browser/base/content/browser.css
--- a/browser/base/content/browser-siteIdentity.js
+++ b/browser/base/content/browser-siteIdentity.js
@@ -818,16 +818,17 @@ var gIdentityHandler = {
       } else {
         this._identityBox.classList.add("weakCipher");
       }
     } else if (this._isCertErrorPage) {
       // We show a warning lock icon for certificate errors, and
       // show the "Not Secure" text.
       this._identityBox.className = "certErrorPage notSecureText";
       icon_label = gNavigatorBundle.getString("identity.notSecure.label");
+      tooltip = gNavigatorBundle.getString("identity.notSecure.tooltip");
     } else if (this._isAboutHttpsOnlyErrorPage) {
       // We show a not secure lock icon for 'about:httpsonlyerror' page.
       this._identityBox.className = "httpsOnlyErrorPage";
     } else if (this._isAboutNetErrorPage || this._isAboutBlockedPage) {
       // Network errors and blocked pages get a more neutral icon
       this._identityBox.className = "unknownIdentity";
     } else if (this._isPotentiallyTrustworthy) {
       // This is a local resource (and shouldn't be marked insecure).
--- a/browser/base/content/browser.css
+++ b/browser/base/content/browser.css
@@ -756,17 +756,17 @@ toolbar:not(#TabsToolbar) > #personal-bo
 
 /* Customize mode is difficult to use at moderate window width if the Urlbar
    remains 350px wide. */
 :root[customizing] #urlbar-container {
   min-width: 280px;
 }
 
 #identity-icon-box {
-  max-width: calc(30px + 10em);
+  max-width: calc(30px + 13em);
 }
 
 @media (max-width: 770px) {
   #urlbar-container {
     min-width: calc(280px + 24px + 2 * var(--toolbarbutton-inner-padding));
   }
   #nav-bar[downloadsbuttonshown] #urlbar-container {
     min-width: 280px;