Bug 1348119. Move the test for setRangeText setting the dirty value flag into upstream wpt. r=smaug
☠☠ backed out by 45fe96225142 ☠ ☠
authorBoris Zbarsky <bzbarsky@mit.edu>
Thu, 16 Mar 2017 17:51:51 -0400
changeset 348193 7b89ee0ae4204848f8d6f8f03ea036b6eeff3814
parent 348192 38e85537c42929c30e1d9153f79ce4d6640a0a9c
child 348194 d97de71c337b0b6289ecf1936480ec797fd0bd77
push id39092
push userkwierso@gmail.com
push dateFri, 17 Mar 2017 18:14:05 +0000
treeherderautoland@88576fd417e7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1348119
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1348119. Move the test for setRangeText setting the dirty value flag into upstream wpt. r=smaug MozReview-Commit-ID: 6yF42plMkAE
testing/web-platform/meta/MANIFEST.json
testing/web-platform/mozilla/meta/MANIFEST.json
testing/web-platform/mozilla/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
testing/web-platform/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -93548,16 +93548,22 @@
     ]
    ],
    "html/semantics/forms/textfieldselection/selection-start-end.html": [
     [
      "/html/semantics/forms/textfieldselection/selection-start-end.html",
      {}
     ]
    ],
+   "html/semantics/forms/textfieldselection/selection-value-interactions.html": [
+    [
+     "/html/semantics/forms/textfieldselection/selection-value-interactions.html",
+     {}
+    ]
+   ],
    "html/semantics/forms/textfieldselection/selection.html": [
     [
      "/html/semantics/forms/textfieldselection/selection.html",
      {
       "timeout": "long"
      }
     ]
    ],
@@ -164827,17 +164833,17 @@
   "geolocation-API/getCurrentPosition_permission_allow.https.html": [
    "695f80f5a06279b3a0bdd137e6a402da66a5eeee",
    "testharness"
   ],
   "geolocation-API/getCurrentPosition_permission_deny-manual.html": [
    "44b2d8846c79ddf7eb8cb3ab76d8899b7e783fad",
    "manual"
   ],
-  "geolocation-API/getCurrentPosition_permission_deny.html": [
+  "geolocation-API/getCurrentPosition_permission_deny.https.html": [
    "28939dd8e719ba66497a814edd1f4500ad348e95",
    "testharness"
   ],
   "geolocation-API/interfaces.html": [
    "c5e300b504b6bf75818fbe79728c87b086ccce3d",
    "testharness"
   ],
   "geolocation-API/support.js": [
@@ -176676,29 +176682,33 @@
    "629f3682421060ea18e9046a637402212be1b1fd",
    "testharness"
   ],
   "html/semantics/forms/textfieldselection/selection-not-application.html": [
    "39ecb031aca3655a06152f94a514981fe59ebbaf",
    "testharness"
   ],
   "html/semantics/forms/textfieldselection/selection-start-end.html": [
-   "1f3184b72aba5631d6db4379dfa98035ee047283",
+   "755fb11ec3d9440d3883ec3e2820a9e77fc144ae",
+   "testharness"
+  ],
+  "html/semantics/forms/textfieldselection/selection-value-interactions.html": [
+   "0f93258e5237c49fa24efe5180409e48721e8025",
    "testharness"
   ],
   "html/semantics/forms/textfieldselection/selection.html": [
-   "f7674721b84ec8fca0e5e40258447ce857b87784",
+   "7f3969423e86313ec20846c84f8deecc95048b82",
    "testharness"
   ],
   "html/semantics/forms/textfieldselection/textfieldselection-setRangeText.html": [
    "3bbd350321f5ec9e0a8f3d47da4e11aaa3ad4d68",
    "testharness"
   ],
   "html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html": [
-   "462049246a2ef3e66c22017ec6ad362e07b467e6",
+   "ffcef015b49fd156cc529117509f0ae0a38234bd",
    "testharness"
   ],
   "html/semantics/forms/the-button-element/.gitkeep": [
    "da39a3ee5e6b4b0d3255bfef95601890afd80709",
    "support"
   ],
   "html/semantics/forms/the-button-element/button-activate-frame.html": [
    "a3dd367a8f7eb9158b1271fcf95bf98b60fe0c9b",
@@ -179456,17 +179466,17 @@
    "0f882828f5cc321992ab9265fe632e55c6d6760b",
    "testharness"
   ],
   "html/webappapis/scripting/events/event-handler-onresize.html": [
    "917a10cd8a60b916eb4e2ad7bb7cb1ae657335a8",
    "testharness"
   ],
   "html/webappapis/scripting/events/event-handler-processing-algorithm.html": [
-   "a7c163d53eb559ea710527cace404ed88e9c4d0a",
+   "9a1fa2065ba742d6ab945065d65bdc0f60783d94",
    "testharness"
   ],
   "html/webappapis/scripting/events/event-handler-spec-example.html": [
    "8d4d0bfdf447591695ac134cd243277ea2326c84",
    "testharness"
   ],
   "html/webappapis/scripting/events/eventhandler-cancellation.html": [
    "491fd73a4ec8812cb8dc1ee01e34a7ff2a07ffb3",
@@ -200136,17 +200146,17 @@
    "0497bf37f0e3b55a6a4745cae2ec700b6f963fd3",
    "testharness"
   ],
   "service-workers/service-worker/performance-timeline.https.html": [
    "23d9e3dc830b83370875387cd5d6e1d5e913452f",
    "testharness"
   ],
   "service-workers/service-worker/postmessage-from-waiting-serviceworker.https.html": [
-   "a3a2734be01c2e410a32daf9342f1e211ce22325",
+   "99519ec3ef70e08fe42fce50bb6e9d643a2daa9f",
    "testharness"
   ],
   "service-workers/service-worker/postmessage-msgport-to-client.https.html": [
    "21ae7fb96321dc75e7063c27b7e6838e6b9ff6c6",
    "testharness"
   ],
   "service-workers/service-worker/postmessage-to-client.https.html": [
    "4f91d302091df45ca72567c2cedc1584ad9045a9",
@@ -200304,17 +200314,17 @@
    "b15855240cf7dbc5df4ee30a544d7ff94935d146",
    "support"
   ],
   "service-workers/service-worker/resources/dummy.txt": [
    "33ab5639bfd8e7b95eb1d8d0b87781d4ffea4d5d",
    "support"
   ],
   "service-workers/service-worker/resources/echo-message-to-source-worker.js": [
-   "449055cd2d8c41f2e3c78a8a748287faee664759",
+   "760b04aa2e36f55cfdbea0871a7424f787734a6e",
    "support"
   ],
   "service-workers/service-worker/resources/empty-but-slow-worker.js": [
    "36ecac2f5ab2d3738ca72a7a7d1c605dbec97ff1",
    "support"
   ],
   "service-workers/service-worker/resources/empty-worker.js": [
    "84b3339c3419e318803e51f46d7252d9e8ac183b",
@@ -219272,17 +219282,17 @@
    "cfaa1c59bdfefe7682fd73152e2d4a706a415aaa",
    "support"
   ],
   "webvtt/webvtt-file-format-parsing/webvtt-file-parsing/support/ids.vtt": [
    "e94efc2cea87f5ebaba3d7a46bdfe1f74cd556ef",
    "support"
   ],
   "webvtt/webvtt-file-format-parsing/webvtt-file-parsing/support/newlines.vtt": [
-   "ba3848383a2197647a9c34c52150991ecb87f22a",
+   "a5bfb88a0066da230fbf05f0cf9d200f73c0bb12",
    "support"
   ],
   "webvtt/webvtt-file-format-parsing/webvtt-file-parsing/support/no-signature.vtt": [
    "71ffec71e6a8923027309dd41c591302ac880550",
    "support"
   ],
   "webvtt/webvtt-file-format-parsing/webvtt-file-parsing/support/nulls.vtt": [
    "140e16000f93f8565c28c2fd12a638afcc6bbf05",
--- a/testing/web-platform/mozilla/meta/MANIFEST.json
+++ b/testing/web-platform/mozilla/meta/MANIFEST.json
@@ -895,17 +895,17 @@
    "6cd254447dea53268ce9ec8ce8a075c7803b5393",
    "testharness"
   ],
   "focus/Selection_setBaseAndExtent.html": [
    "cd25aacffbaabbeafa443140f9b08ff75a838116",
    "testharness"
   ],
   "html/semantics/forms/textfieldselection/selection-value-interactions.html": [
-   "6c5e95a8f2f11d106e669eb82b46ffff73d08335",
+   "2083d78d4a6a7b48994f17909790dfeb1ac903ae",
    "testharness"
   ],
   "html/semantics/scripting-1/the-script-element/create-module-script.html": [
    "3214bced5d81e8001a321aea4c80675b6603b11d",
    "testharness"
   ],
   "html/semantics/scripting-1/the-script-element/reload-failed-module-script.html": [
    "5b8cf6809bd8d0797f4172bf9a01f9085c0abbaf",
--- a/testing/web-platform/mozilla/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
+++ b/testing/web-platform/mozilla/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
@@ -195,25 +195,9 @@ for (var data of elemData) {
       assert_equals(el.selectionStart, shorttext.length,
                     "Should have adjusted selection start");
       assert_equals(el.selectionEnd, shorttext.length,
                     "Should have adjusted selection end");
     }
   }, `selection location after defaultValue set to shorter than selectionStart of ${data.desc}`);
 }
 
-for (var data of elemData) {
-  test(function() {
-    var el = data.factory();
-    this.add_cleanup(() => el.remove());
-    el.defaultValue = sometext;
-    assert_true(sometext.length > 8,
-                "sometext too short, test won't work right");
-    el.selectionStart = 4;
-    el.selectionEnd = 6;
-    el.setRangeText("xyz");
-    el.defaultValue = "set range text";
-    assert_equals(el.value, sometext.slice(0, 4) + "xyz" + sometext.slice(6),
-                  "Calling setRangeText should set the value dirty flag");
-  }, `value dirty flag behavior after setRangeText on ${data.desc}`);
-}
-
 </script>
copy from testing/web-platform/mozilla/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
copy to testing/web-platform/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
--- a/testing/web-platform/mozilla/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
+++ b/testing/web-platform/tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
@@ -75,140 +75,16 @@
       },
     },
   ];
 
 for (var data of elemData) {
   test(function() {
     var el = data.factory();
     this.add_cleanup(() => el.remove());
-    assert_equals(el.selectionStart, 0,
-                  `Cursor start should be at beginning of ${data.desc}`);
-    assert_equals(el.selectionEnd, 0,
-                  `Cursor end should be at beginning of ${data.desc}`);
-  }, `cursor location for initial value of ${data.desc}`);
-}
-
-for (var data of elemData) {
-  test(function() {
-    var el = data.factory();
-    this.add_cleanup(() => el.remove());
-    el.defaultValue = sometext;
-    // The "focused or has been focused" case behaves differently.
-    if (data.desc.includes("focused")) {
-      assert_equals(el.selectionStart, el.value.length,
-                    `Cursor start should be at end of ${data.desc}`);
-      assert_equals(el.selectionEnd, el.value.length,
-                    `Cursor end should be at end of ${data.desc}`);
-    } else {
-      assert_equals(el.selectionStart, 0,
-                    `Cursor start should be at beginning of ${data.desc}`);
-      assert_equals(el.selectionEnd, 0,
-                    `Cursor end should be at beginning of ${data.desc}`);
-    }
-  }, `cursor location after defaultValue set of ${data.desc}`);
-}
-
-for (var data of elemData) {
-  test(function() {
-    var el = data.factory();
-    this.add_cleanup(() => el.remove());
-    el.selectionStart = el.selectionStart;
-    el.defaultValue = sometext;
-    // The focused case behaves differently.
-    if (data.desc.includes("focused")) {
-      assert_equals(el.selectionStart, el.value.length,
-                    `Cursor start should be at end of ${data.desc}`);
-      assert_equals(el.selectionEnd, el.value.length,
-                    `Cursor end should be at end of ${data.desc}`);
-    } else {
-      assert_equals(el.selectionStart, 0,
-                    `Cursor start should be at beginning of ${data.desc}`);
-      assert_equals(el.selectionEnd, 0,
-                    `Cursor end should be at beginning of ${data.desc}`);
-    }
-  }, `cursor location after defaultValue set after no-op selectionStart set of ${data.desc}`);
-}
-
-for (var data of elemData) {
-  test(function() {
-    var el = data.factory();
-    this.add_cleanup(() => el.remove());
-    el.value = sometext;
-    assert_equals(el.selectionStart, sometext.length,
-                  `Cursor start should be at end of ${data.desc}`);
-    assert_equals(el.selectionEnd, sometext.length,
-                  `Cursor end should be at end of ${data.desc}`);
-  }, `cursor location after value set of ${data.desc}`);
-}
-
-for (var data of elemData) {
-  test(function() {
-    var el = data.factory();
-    this.add_cleanup(() => el.remove());
-    assert_true(sometext.length > 8,
-                "sometext too short, test won't work right");
-    el.defaultValue = sometext;
-    el.selectionStart = 1;
-    el.selectionEnd = 8;
-    assert_equals(el.selectionStart, 1, "We just set selectionStart!");
-    assert_equals(el.selectionEnd, 8, "We just set selectionEnd!");
-    assert_true(shorttext.length > 1,
-                "shorttext too short, test won't work right");
-    assert_true(shorttext.length < 8,
-                "shorttext too long, test won't work right");
-    el.defaultValue = shorttext;
-    // The "focused or has been focused" case behaves differently.
-    if (data.desc.includes("focused")) {
-      assert_equals(el.selectionStart, el.value.length,
-                    `Cursor start should be at end of ${data.desc}`);
-      assert_equals(el.selectionEnd, el.value.length,
-                    `Cursor end should be at end of ${data.desc}`);
-    } else {
-      assert_equals(el.selectionStart, 1,
-                    "Shouldn't have moved selection start");
-      assert_equals(el.selectionEnd, shorttext.length,
-                    "Should have adjusted selection end");
-    }
-  }, `selection location after defaultValue set to shorter than selectionEnd of ${data.desc}`);
-}
-
-for (var data of elemData) {
-  test(function() {
-    var el = data.factory();
-    this.add_cleanup(() => el.remove());
-    assert_true(sometext.length > 8,
-                "sometext too short, test won't work right");
-    el.defaultValue = sometext;
-    el.selectionStart = 5;
-    el.selectionEnd = 8;
-    assert_equals(el.selectionStart, 5, "We just set selectionStart!");
-    assert_equals(el.selectionEnd, 8, "We just set selectionEnd!");
-    assert_true(shorttext.length < 5,
-                "shorttext too long, test won't work right");
-    el.defaultValue = shorttext;
-    // The "focused or has been focused" case behaves differently.
-    if (data.desc.includes("focused")) {
-      assert_equals(el.selectionStart, el.value.length,
-                    `Cursor start should be at end of ${data.desc}`);
-      assert_equals(el.selectionEnd, el.value.length,
-                    `Cursor end should be at end of ${data.desc}`);
-    } else {
-      assert_equals(el.selectionStart, shorttext.length,
-                    "Should have adjusted selection start");
-      assert_equals(el.selectionEnd, shorttext.length,
-                    "Should have adjusted selection end");
-    }
-  }, `selection location after defaultValue set to shorter than selectionStart of ${data.desc}`);
-}
-
-for (var data of elemData) {
-  test(function() {
-    var el = data.factory();
-    this.add_cleanup(() => el.remove());
     el.defaultValue = sometext;
     assert_true(sometext.length > 8,
                 "sometext too short, test won't work right");
     el.selectionStart = 4;
     el.selectionEnd = 6;
     el.setRangeText("xyz");
     el.defaultValue = "set range text";
     assert_equals(el.value, sometext.slice(0, 4) + "xyz" + sometext.slice(6),