Bug 1471285 - [Clang-Tidy 5.0.1] Checker misc-suspicious-missing-comma has faulty test case. r=janx
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Tue, 26 Jun 2018 17:44:44 +0100
changeset 424195 77cadf8638c6e1f26f4a1de403a8267484969236
parent 424194 028265406fe7486dc66f142e234927f7b3736f20
child 424196 df9adbd9911340b0d3174db8377d9ebc35c34661
push id65683
push userbpostelnicu@mozilla.com
push dateThu, 28 Jun 2018 12:14:16 +0000
treeherderautoland@77cadf8638c6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjanx
bugs1471285
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1471285 - [Clang-Tidy 5.0.1] Checker misc-suspicious-missing-comma has faulty test case. r=janx MozReview-Commit-ID: 2COIi47WQBO
tools/clang-tidy/test/misc-suspicious-missing-comma.cpp
tools/clang-tidy/test/misc-suspicious-missing-comma.json
--- a/tools/clang-tidy/test/misc-suspicious-missing-comma.cpp
+++ b/tools/clang-tidy/test/misc-suspicious-missing-comma.cpp
@@ -1,9 +1,9 @@
-
-// misc-suspicious-missing-comma
-const char* software[] = {
-  "Firefox",
-  "Rust"   // There is a missing comma here.
-  "Thunderbird",
-  "kinto"
+const char* Cartoons[] = {
+  "Bugs Bunny",
+  "Homer Simpson",
+  "Mickey Mouse",
+  "Bart Simpson",
+  "Charlie Brown"  // There is a missing comma here.
+  "Fred Flintstone",
+  "Popeye",
 };
-
--- a/tools/clang-tidy/test/misc-suspicious-missing-comma.json
+++ b/tools/clang-tidy/test/misc-suspicious-missing-comma.json
@@ -1,1 +1,1 @@
-"[]"
\ No newline at end of file
+"[[\"warning\", \"suspicious string literal, probably missing a comma\", \"misc-suspicious-missing-comma\"]]"
\ No newline at end of file