Bug 1564870 - Add --no-enable-webrender flag to wpt, r=maja_zf
authorJames Graham <james@hoppipolla.co.uk>
Thu, 11 Jul 2019 02:20:18 +0000
changeset 482360 76af8bbce61aedb0dbc30691e2a4f9dccf6018bf
parent 482359 b7ed8f6a305f6bbb684c3fedd81f713115fee61c
child 482361 203e09f37d1f38b5f6f7de0fd8dc181a66d6daa2
push id89717
push userjames@hoppipolla.co.uk
push dateThu, 11 Jul 2019 09:13:00 +0000
treeherderautoland@76af8bbce61a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmaja_zf
bugs1564870
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1564870 - Add --no-enable-webrender flag to wpt, r=maja_zf This allows us to be more explicit about when the feature is enabled or not, rather than relying on the defaults. Differential Revision: https://phabricator.services.mozilla.com/D37554
testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py
@@ -251,18 +251,20 @@ scheme host and port.""")
     ssl_group.add_argument("--host-cert-path", action="store", type=abs_path,
                         help="Path to host certificate when using pregenerated ssl certificates")
 
     gecko_group = parser.add_argument_group("Gecko-specific")
     gecko_group.add_argument("--prefs-root", dest="prefs_root", action="store", type=abs_path,
                              help="Path to the folder containing browser prefs")
     gecko_group.add_argument("--disable-e10s", dest="gecko_e10s", action="store_false", default=True,
                              help="Run tests without electrolysis preferences")
-    gecko_group.add_argument("--enable-webrender", dest="enable_webrender", action="store_true", default=False,
-                             help="Enable the WebRender compositor in Gecko.")
+    gecko_group.add_argument("--enable-webrender", dest="enable_webrender", action="store_true", default=None,
+                             help="Enable the WebRender compositor in Gecko (defaults to disabled).")
+    gecko_group.add_argument("--no-enable-webrender", dest="enable_webrender", action="store_false",
+                             help="Disable the WebRender compositor in Gecko.")
     gecko_group.add_argument("--stackfix-dir", dest="stackfix_dir", action="store",
                              help="Path to directory containing assertion stack fixing scripts")
     gecko_group.add_argument("--lsan-dir", dest="lsan_dir", action="store",
                              help="Path to directory containing LSAN suppressions file")
     gecko_group.add_argument("--setpref", dest="extra_prefs", action='append',
                              default=[], metavar="PREF=VALUE",
                              help="Defines an extra user preference (overrides those in prefs_root)")
     gecko_group.add_argument("--leak-check", dest="leak_check", action="store_true", default=None,
@@ -547,16 +549,19 @@ def check_args(kwargs):
         kwargs["reftest_internal"] = True
 
     if kwargs["lsan_dir"] is None:
         kwargs["lsan_dir"] = kwargs["prefs_root"]
 
     if kwargs["reftest_screenshot"] is None:
         kwargs["reftest_screenshot"] = "unexpected"
 
+    if kwargs["enable_webrender"] is None:
+        kwargs["enable_webrender"] = False
+
     return kwargs
 
 
 def check_args_update(kwargs):
     set_from_config(kwargs)
 
     if kwargs["product"] is None:
         kwargs["product"] = "firefox"