Backed out changeset 37ac6d023498 (bug 1481655) for bustage at build/src/gfx/layers/wr/WebRenderCommandBuilder.cpp on a CLOSED TREE
authordvarga <dvarga@mozilla.com>
Wed, 08 Aug 2018 21:00:23 +0300
changeset 430580 74910b7a444fbbdb6399a15e19593a3c30790eec
parent 430579 37ac6d023498780dd12fecb5acdc4c222d452505
child 430581 08909429c467887a03229ee1eaa71abf72139c1c
push id67524
push userdvarga@mozilla.com
push dateWed, 08 Aug 2018 18:01:30 +0000
treeherderautoland@74910b7a444f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1481655
milestone63.0a1
backs out37ac6d023498780dd12fecb5acdc4c222d452505
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 37ac6d023498 (bug 1481655) for bustage at build/src/gfx/layers/wr/WebRenderCommandBuilder.cpp on a CLOSED TREE
gfx/layers/wr/WebRenderCommandBuilder.cpp
--- a/gfx/layers/wr/WebRenderCommandBuilder.cpp
+++ b/gfx/layers/wr/WebRenderCommandBuilder.cpp
@@ -743,19 +743,17 @@ struct DIGroup
         MOZ_RELEASE_ASSERT(!data->mInvalid);
       }
 
       nsDisplayList* children = item->GetChildren();
       if (children) {
         GP("doing children in EndGroup\n");
         aGrouper->PaintContainerItem(this, item, bounds, children, aContext, aRecorder);
       } else {
-        // Hit test items don't have anything to paint so skip them. Ideally we
-        // would drop these items earlier...
-        if (dirty && item->Type() != DisplayItemType::TYPE_COMPOSITOR_HITTEST_INFO) {
+        if (dirty) {
           // What should the clip settting strategy be? We can set the full clip everytime.
           // this is probably easiest for now. An alternative would be to put the push and the pop
           // into separate items and let invalidation handle it that way.
           DisplayItemClip currentClip = item->GetClip();
 
           if (currentClip.HasClip()) {
             aContext->Save();
             currentClip.ApplyTo(aContext, aGrouper->mAppUnitsPerDevPixel);