Bug 1745116 - disable ThreadMetrics.CollectMetrics on windows x64 r=intermittent-reviewers,MasterWayZ DONTBUILD
authorCristian Tuns <ctuns@mozilla.com>
Mon, 10 Jan 2022 13:05:27 +0000
changeset 604060 73f018a3325f6be96fd6d70fc1918b2f8c23a1da
parent 604059 0d819715f3f1f087db54486e5237048878a70bc9
child 604061 d00b5ccb5aedcff9b88a69275e0299f7bb79b1ac
push id155776
push userctuns@mozilla.com
push dateMon, 10 Jan 2022 13:07:50 +0000
treeherderautoland@73f018a3325f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersintermittent-reviewers, MasterWayZ
bugs1745116
milestone97.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1745116 - disable ThreadMetrics.CollectMetrics on windows x64 r=intermittent-reviewers,MasterWayZ DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D135475
xpcom/tests/gtest/TestThreadMetrics.cpp
--- a/xpcom/tests/gtest/TestThreadMetrics.cpp
+++ b/xpcom/tests/gtest/TestThreadMetrics.cpp
@@ -154,16 +154,18 @@ class ThreadMetrics : public ::testing::
   RefPtr<DocGroup> mDocGroup;
   RefPtr<DocGroup> mDocGroup2;
   RefPtr<PerformanceCounter> mCounter;
   RefPtr<PerformanceCounter> mCounter2;
   nsCOMPtr<nsIThreadManager> mThreadMgr;
   uint32_t mDispatchCount;
 };
 
+// Disabled on Windows x64 due to high failure rate in bug 1745116
+#if !defined(_WIN64)
 TEST_F(ThreadMetrics, CollectMetrics) {
   nsresult rv;
   initScheduler();
 
   // Dispatching a runnable that will last for +50ms
   nsCOMPtr<nsIRunnable> runnable = new TimedRunnable(25, 25);
   rv = Dispatch(runnable);
   ASSERT_TRUE(NS_SUCCEEDED(rv));
@@ -180,16 +182,17 @@ TEST_F(ThreadMetrics, CollectMetrics) {
       ASSERT_EQ(mCounter->GetDispatchCounter()[i], 0u);
     }
   }
 
   // Did we get incremented in the docgroup ?
   uint64_t duration = mCounter->GetExecutionDuration();
   ASSERT_GE(duration, 50000u);
 }
+#endif
 
 TEST_F(ThreadMetrics, CollectRecursiveMetrics) {
   nsresult rv;
 
   initScheduler();
 
   // Dispatching a runnable that will last for +50ms
   // and run another one recursively that lasts for 400ms