Bug 1364651 - annotate mach bash hack; r=Callek
authorRob Thijssen <rthijssen@mozilla.com>
Mon, 12 Jun 2017 12:19:05 +0300
changeset 363660 71a661bc483c
parent 363659 d0f17a12ae61
child 363661 d6fadd1aa4fc
push id44634
push userryanvm@gmail.com
push dateTue, 13 Jun 2017 14:00:46 +0000
treeherderautoland@71a661bc483c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersCallek
bugs1364651
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1364651 - annotate mach bash hack; r=Callek MozReview-Commit-ID: AQHeHLBABZg
testing/mozharness/mozharness/mozilla/building/buildbase.py
--- a/testing/mozharness/mozharness/mozilla/building/buildbase.py
+++ b/testing/mozharness/mozharness/mozilla/building/buildbase.py
@@ -1618,16 +1618,18 @@ or run without that action (ie: --no-{ac
         buildprops = os.path.join(dirs['base_work_dir'], 'buildprops.json')
         # not finding buildprops is not an error outside of buildbot
         if os.path.exists(buildprops):
             self.copyfile(
                 buildprops,
                 os.path.join(dirs['abs_work_dir'], 'buildprops.json'))
 
         if 'MOZILLABUILD' in os.environ:
+            # We found many issues with intermittent build failures when not invoking mach via bash.
+            # See bug 1364651 before considering changing.
             mach = [
                 os.path.join(os.environ['MOZILLABUILD'], 'msys', 'bin', 'bash.exe'),
                 os.path.join(dirs['abs_src_dir'], 'mach')
             ]
         else:
             mach = [sys.executable, 'mach']
 
         return_code = self.run_command_m(