Backed out changeset e9ea26dd5b68 (bug 1539318) for crashtest failures on 1539318-1.html.
authorCosmin Sabou <csabou@mozilla.com>
Thu, 02 May 2019 03:18:12 +0300
changeset 472224 6f280783594b75caee682ed71c8155934a9d59d9
parent 472223 ec0b7325a41ee416eefe67c1358d6ad826e4e72d
child 472225 f446fb2da3fb1b6e30f6de6b0f6ed1b5cfcda071
push id84527
push usercsabou@mozilla.com
push dateThu, 02 May 2019 00:18:48 +0000
treeherderautoland@6f280783594b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1539318
milestone68.0a1
backs oute9ea26dd5b6860369222508e8510888db71c1de4
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset e9ea26dd5b68 (bug 1539318) for crashtest failures on 1539318-1.html.
layout/svg/SVGTextFrame.cpp
layout/svg/crashtests/1539318-1.svg
layout/svg/crashtests/crashtests.list
--- a/layout/svg/SVGTextFrame.cpp
+++ b/layout/svg/SVGTextFrame.cpp
@@ -3661,26 +3661,16 @@ uint32_t SVGTextFrame::GetNumberOfChars(
   return n;
 }
 
 /**
  * Implements the SVG DOM GetComputedTextLength method for the specified
  * text child element.
  */
 float SVGTextFrame::GetComputedTextLength(nsIContent* aContent) {
-  nsIFrame* kid = PrincipalChildList().FirstChild();
-  if (NS_SUBTREE_DIRTY(kid)) {
-    // We're never reflowed if we're under a non-SVG element that is
-    // never reflowed (such as the HTML 'caption' element).
-    //
-    // If we ever decide that we need to return accurate values here,
-    // we could do similar work to GetSubStringLength.
-    return 0;
-  }
-
   UpdateGlyphPositioning();
 
   float cssPxPerDevPx = nsPresContext::AppUnitsToFloatCSSPixels(
       PresContext()->AppUnitsPerDevPixel());
 
   nscoord length = 0;
   TextRenderedRunIterator it(this, TextRenderedRunIterator::eAllFrames,
                              aContent);
deleted file mode 100644
--- a/layout/svg/crashtests/1539318-1.svg
+++ /dev/null
@@ -1,10 +0,0 @@
-<script>
-window.onload = function() {
-  a.getComputedTextLength()
-}
-</script>
-<body>
-<svg>
-<switch>
-<hatch>
-<text id="a">A</text>
--- a/layout/svg/crashtests/crashtests.list
+++ b/layout/svg/crashtests/crashtests.list
@@ -221,9 +221,9 @@ load 1480224.html
 load 1502936.html
 load 1504918.svg
 load perspective-invalidation.html
 load invalid_url.html
 load 1535517-1.svg
 load 1504072.html
 load 1072758.html
 load 1536892.html
-load 1539318-1.html
+