Bug 1760895 [wpt PR 33310] - Reland "Create property tree nodes for will-change only when relevant property has will-change.", a=testonly
☠☠ backed out by ee5983c94e61 ☠ ☠
authorL. David Baron <dbaron@chromium.org>
Thu, 24 Mar 2022 12:20:20 +0000
changeset 612257 6b4461f3dda7e8b972277c2510c968a6660e624e
parent 612256 667ab8803963fd129c889de7ff6b625ae273b768
child 612258 b0bed59e149558f86d38f1a9cb57da0bf9651adf
push id160097
push userwptsync@mozilla.com
push dateSat, 26 Mar 2022 10:59:49 +0000
treeherderautoland@413e58ffed69 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1760895, 33310, 900241, 3328730, 983821, 3543395, 984106
milestone100.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1760895 [wpt PR 33310] - Reland "Create property tree nodes for will-change only when relevant property has will-change.", a=testonly Automatic update from web-platform-tests Reland "Create property tree nodes for will-change only when relevant property has will-change." This is a reland of commit 5d3dd81ee4f41ffc7fd40fda745cb097cd50e9f5 Original change's description: > Create property tree nodes for will-change only when relevant property has will-change. > > Prior to this change, will-change: transform, opacity, filter, or > backdrop-filter would cause the creation of property tree nodes (in both > the paint property tree and the cc property tree) for all of them > (though only a single effect property node for both opacity and > backdrop-filter). > > With this change, will-change: transform only causes the creation of a > transform node (in the transform tree), will-change: filter only causes > the creation of a filter node (in the effect tree), and will-change: > opacity or backdrop-filter only causes the creation of an effect node > (in the effect tree). However, *if* the nodes are created by something > else, the presence of a different will-change still causes any node that > is created in the paint property tree to be composited (i.e., created in > the cc property tree). > > This provides the basis on which we can separate the transform node into > multiple transform nodes, for efficient implementation and animation of > individual transform properties, without causing a performance > regression. > > Earlier versions of this CL (prior to the change that kept nodes being > composited for an unrelated will-change) caused the test > external/wpt/css/filter-effects/effect-reference-feimage-002.html to > start failing (in the same way as -001 and -003) because the filter > effect is no longer composited. It creates a copy of the test as -004 > with will-change: filter rather than will-change: transform that > continues to have a composited filter effect node and thus continues > passing even with that earlier change. This test still seems worth > adding despite no longer strictly being needed. > > Bug: 900241 > Change-Id: I18efc630668ea7eac2a8c0a0417b766762e71d9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328730 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: David Baron <dbaron@chromium.org> > Cr-Commit-Position: refs/heads/main@{#983821} Bug: 900241 Change-Id: Ic760f2d303f56c1ab9c276a510b9eff82e53179b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543395 Auto-Submit: David Baron <dbaron@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#984106} -- wpt-commits: ed4f727e4e7960a8af929a51712c46b007ecadf1 wpt-pr: 33310
testing/web-platform/tests/css/filter-effects/effect-reference-feimage-004.html
testing/web-platform/tests/css/filter-effects/reference/effect-reference-feimage-004-ref.html
copy from testing/web-platform/tests/css/filter-effects/effect-reference-feimage-002.html
copy to testing/web-platform/tests/css/filter-effects/effect-reference-feimage-004.html
--- a/testing/web-platform/tests/css/filter-effects/effect-reference-feimage-002.html
+++ b/testing/web-platform/tests/css/filter-effects/effect-reference-feimage-004.html
@@ -1,20 +1,20 @@
 <!DOCTYPE html>
 <title>CSS Filters: feImage and CSS reference filters.</title>
 <link rel="help" href="https://drafts.fxtf.org/filter-effects-1/#feImageElement">
 <link rel="help" href="https://drafts.fxtf.org/filter-effects-1/#FilterProperty">
-<link rel="match" href="reference/effect-reference-feimage-002-ref.html">
-<meta name="assert" content="This test ensures that CSS reference filters with 'will-change: transform' supports feImage."/>
+<link rel="match" href="reference/effect-reference-feimage-004-ref.html">
+<meta name="assert" content="This test ensures that CSS reference filters with 'will-change: filter' supports feImage."/>
 <style>
   #filtered {
     width: 160px;
     height: 90px;
     filter: url(#imagereplace);
-    will-change: transform;
+    will-change: filter;
   }
 </style>
 <div id="filtered"></div>
 <svg width="0" height="0">
   <filter id="imagereplace" color-interpolation-filters="sRGB" x="0%" y="0%" width="100%" height="100%">
      <feimage xlink:href="support/color-palette.png"/>
   </filter>
 </svg>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/filter-effects/reference/effect-reference-feimage-004-ref.html
@@ -0,0 +1,2 @@
+<!DOCTYPE html>
+<img src="../support/color-palette.png" style="will-change: filter;">