Bug 1547369 - Rename Compositor::RequestRecordFrames to Compositor::RequestAllowFrameRecording r=mstange
authorBarret Rennie <barret@brennie.ca>
Thu, 02 May 2019 17:33:38 +0000
changeset 472324 68e1511514dfeabaa403e29a8bfa950f7e4b0c8d
parent 472323 0ffeaa8ab59c66bf9a0dd6f36a3959770ba3eeb0
child 472325 98a5645c05669d1ad56bf3d6f5f602869e477876
push id84599
push userbrennie@mozilla.com
push dateThu, 02 May 2019 17:34:47 +0000
treeherderautoland@98a5645c0566 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1547369
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1547369 - Rename Compositor::RequestRecordFrames to Compositor::RequestAllowFrameRecording r=mstange Differential Revision: https://phabricator.services.mozilla.com/D29708
gfx/layers/Compositor.h
gfx/layers/basic/BasicCompositor.h
gfx/layers/composite/LayerManagerComposite.cpp
--- a/gfx/layers/Compositor.h
+++ b/gfx/layers/Compositor.h
@@ -518,21 +518,21 @@ class Compositor : public TextureSourceP
 
   // A stale Compositor has no CompositorBridgeParent; it will not process
   // frames and should not be used.
   void SetInvalid();
   bool IsValid() const override;
   CompositorBridgeParent* GetCompositorBridgeParent() const { return mParent; }
 
   /**
-   * Request the compositor to record its frames.
+   * Request the compositor to allow recording its frames.
    *
    * For all compositors except |BasicCompositor|, this is a noop.
    */
-  virtual void RequestRecordFrames(bool aWillRecord) {}
+  virtual void RequestAllowFrameRecording(bool aWillRecord) {}
 
   /**
    * Record the current frame for readback by the |CompositionRecorder|.
    *
    * If this compositor does not support this feature, a null pointer is
    * returned instead.
    */
   already_AddRefed<RecordedFrame> RecordFrame(const TimeStamp& aTimeStamp);
--- a/gfx/layers/basic/BasicCompositor.h
+++ b/gfx/layers/basic/BasicCompositor.h
@@ -140,17 +140,17 @@ class BasicCompositor : public Composito
   }
 
   gfx::DrawTarget* GetDrawTarget() { return mDrawTarget; }
 
   bool IsPendingComposite() override { return mIsPendingEndRemoteDrawing; }
 
   void FinishPendingComposite() override;
 
-  virtual void RequestRecordFrames(bool aWillRecord) override {
+  virtual void RequestAllowFrameRecording(bool aWillRecord) override {
     mRecordFrames = aWillRecord;
   }
 
  private:
   template <typename Geometry>
   void DrawGeometry(const Geometry& aGeometry, const gfx::Rect& aRect,
                     const gfx::IntRect& aClipRect,
                     const EffectChain& aEffectChain, gfx::Float aOpacity,
--- a/gfx/layers/composite/LayerManagerComposite.cpp
+++ b/gfx/layers/composite/LayerManagerComposite.cpp
@@ -891,17 +891,17 @@ void LayerManagerComposite::Render(const
                                    const nsIntRegion& aOpaqueRegion) {
   AUTO_PROFILER_LABEL("LayerManagerComposite::Render", GRAPHICS);
 
   if (mDestroyed || !mCompositor || mCompositor->IsDestroyed()) {
     NS_WARNING("Call on destroyed layer manager");
     return;
   }
 
-  mCompositor->RequestRecordFrames(!!mCompositionRecorder);
+  mCompositor->RequestAllowFrameRecording(!!mCompositionRecorder);
 
   ClearLayerFlags(mRoot);
 
   // At this time, it doesn't really matter if these preferences change
   // during the execution of the function; we should be safe in all
   // permutations. However, may as well just get the values onces and
   // then use them, just in case the consistency becomes important in
   // the future.